OpenConceptLab/ocl_issues#1416 Properly logging exception

OpenConceptLab · Jan 25, 2023 · 05e47cf · 05e47cf
1 parent 2b61735
commit 05e47cf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/core/code_systems/serializers.py b/core/code_systems/serializers.py
@@ -211,9 +211,9 @@ def to_representation(self, instance):
         try:
             rep = super().to_representation(instance)
             IdentifierSerializer.include_ocl_identifier(instance.uri, RESOURCE_TYPE, rep)
-        except Exception as error:
+        except (Exception, ):
             msg = f'Failed to represent "{instance.uri}" as {RESOURCE_TYPE}'
-            logger.error(msg, error)
+            logger.exception(msg)
             return {
                 'resourceType': 'OperationOutcome',
                 'issue': [{

diff --git a/core/concept_maps/serializers.py b/core/concept_maps/serializers.py
@@ -122,9 +122,9 @@ def to_representation(self, instance):
         try:
             rep = super().to_representation(instance)
             IdentifierSerializer.include_ocl_identifier(instance.uri, RESOURCE_TYPE, rep)
-        except Exception as error:
+        except (Exception, ):
             msg = f'Failed to represent "{instance.uri}" as {RESOURCE_TYPE}'
-            logger.error(msg, error)
+            logger.exception(msg)
             return {
                 'resourceType': 'OperationOutcome',
                 'issue': [{

diff --git a/core/value_sets/serializers.py b/core/value_sets/serializers.py
@@ -206,9 +206,9 @@ def to_representation(self, instance):
         try:
             rep = super().to_representation(instance)
             IdentifierSerializer.include_ocl_identifier(instance.uri, RESOURCE_TYPE, rep)
-        except Exception as error:
+        except (Exception, ):
             msg = f'Failed to represent "{instance.uri}" as {RESOURCE_TYPE}'
-            logger.error(msg, error)
+            logger.exception(msg)
             return {
                 'resourceType': 'OperationOutcome',
                 'issue': [{