Fixing build | pylint fixes

OpenConceptLab · Nov 9, 2021 · 92485be · 92485be
1 parent 8f6fea4
commit 92485be
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 16 deletions.
diff --git a/core/collections/views.py b/core/collections/views.py
@@ -616,13 +616,12 @@ def get_object(self, queryset=None):
         return instance
 
     def put(self, request, **kwargs):  # pylint: disable=unused-argument
-        result = self.perform_update()
-        return Response(
-            dict(state=result.state, task=result.task_id, queue='concurrent'), status=status.HTTP_202_ACCEPTED)
+        self.perform_update()
+        return Response(status=status.HTTP_202_ACCEPTED)
 
     def perform_update(self):
         instance = self.get_object()
-        return instance.update_children_counts()
+        instance.update_children_counts()
 
 
 class CollectionVersionSummaryView(CollectionBaseView, RetrieveAPIView):
@@ -639,13 +638,12 @@ def get_object(self, queryset=None):
         return instance
 
     def put(self, request, **kwargs):  # pylint: disable=unused-argument
-        result = self.perform_update()
-        return Response(
-            dict(state=result.state, task=result.task_id, queue='concurrent'), status=status.HTTP_202_ACCEPTED)
+        self.perform_update()
+        return Response(status=status.HTTP_202_ACCEPTED)
 
     def perform_update(self):
         instance = self.get_object()
-        return instance.update_children_counts()
+        instance.update_children_counts()
 
 
 class CollectionLatestVersionSummaryView(CollectionVersionBaseView, RetrieveAPIView, UpdateAPIView):

diff --git a/core/concepts/models.py b/core/concepts/models.py
@@ -150,7 +150,12 @@ class Meta:
             models.Index(name='concepts_public_conditional', fields=['public_access'],
                          condition=(Q(is_active=True) & Q(retired=False) & Q(is_latest_version=True) &
                                     ~Q(public_access='None'))),
-            GinIndex(name='concepts_uri_trgm_id_gin_idx', fields=['uri', 'id'], opclasses=['gin_trgm_ops', 'int8_ops'], condition=Q(is_latest_version=True))
+            GinIndex(
+                name='concepts_uri_trgm_id_gin_idx',
+                fields=['uri', 'id'],
+                opclasses=['gin_trgm_ops', 'int8_ops'],
+                condition=Q(is_latest_version=True)
+            )
         ] + VersionedModel.Meta.indexes
 
     external_id = models.TextField(null=True, blank=True)

diff --git a/core/sources/views.py b/core/sources/views.py
@@ -446,9 +446,8 @@ def get_object(self, queryset=None):
         return instance
 
     def put(self, request, **kwargs):  # pylint: disable=unused-argument
-        result = self.perform_update()
-        return Response(
-            dict(state=result.state, task=result.task_id, queue='concurrent'), status=status.HTTP_201_CREATED)
+        self.perform_update()
+        return Response(status=status.HTTP_202_ACCEPTED)
 
     def perform_update(self):
         instance = self.get_object()
@@ -469,13 +468,12 @@ def get_object(self, queryset=None):
         return instance
 
     def put(self, request, **kwargs):  # pylint: disable=unused-argument
-        result = self.perform_update()
-        return Response(
-            dict(state=result.state, task=result.task_id, queue='concurrent'), status=status.HTTP_202_ACCEPTED)
+        self.perform_update()
+        return Response(status=status.HTTP_202_ACCEPTED)
 
     def perform_update(self):
         instance = self.get_object()
-        return instance.update_children_counts()
+        instance.update_children_counts()
 
 
 class SourceLatestVersionSummaryView(SourceVersionBaseView, RetrieveAPIView, UpdateAPIView):