Use CETL's polymorphic RTTI

[serges147]

• Now CETL's polymorphic RTTI casting is in use at cetl::detail::base_storage.
• Extended unit tests TestXxx helper types with virtual what() method - to test polymorphic RTTI casting.
• Added compile tests to verify several static_assert-s at cetl::any (related to Footprint fitting).

Also:

• Reduced code duplication at unit tests TestXxx helper types.
• Fixed incorrect applying of -fno-exceptions to C flags - should be C++ flags.
• Addressed several unit tests todo-s. No todo-s anymore at production cetl::any code.
• Added verification that there will be no value moved out of source any in case of bad cast attempt.

This change was also made, but decided to revert (for now) and save it as patch (for future reference):

• Added new CETLVAST_DISABLE_CPP_RTTI configuration parameter. OFF by default.
  CETLVAST_DISABLE_CPP_RTTI.patch

[pavel-kirienko]

Here, we are stepping on a slippery slope of relying on implementation-specific features. In general, as far as I know, the C++ standard provides no feature test macro for RTTI:

I would limit our implementation of any to CETL RTTI only.

From our earlier conversations, I understood that you were adding the type informer handler value_type_informer_ in order to support CETL RTTI rather than the standard typeid.

[serges147]

ok, I didn't know that __cpp_rtti is some kind of an extension. I will remove related stuff and stick with our CETL RTTI only. Could you please give a link (or pdf) from where you made the screenshot - for future reference. Thnx!

[pavel-kirienko]

here: https://github.com/cplusplus/draft/releases/tag/n4917

[sonarcloud]

Quality Gate failed

Failed conditions
36.3% Coverage on New Code (required ≥ 90%)

See analysis details on SonarCloud

[pavel-kirienko]

I think it's fine overall but there's one case that should be working but it's not; there's a missing remove_cv somewhere:

#include <cetl/any.hpp>
#include <iostream>
#include <string>


namespace cetl
{
template <>
constexpr type_id type_id_value<int> = {1,2,3,4,5};
template <>
constexpr type_id type_id_value<std::string> = {1,2,3,4,6};
}


int main()
{
    cetl::any<64> any;
    any.emplace<std::string>("hello");
    std::cout << *cetl::any_cast<std::string>(&any) << std::endl;
    std::cout << *cetl::any_cast<const std::string>(&any) << std::endl;  // here
}

[serges147]

>should be working but it's not

I'll take a look at this