Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the translational/rotational segregation in reg.udral.physics.kinematics and reg.udral.physics.dynamics #130

Closed
pavel-kirienko opened this issue Nov 5, 2022 · 1 comment
Closed

Remove the translational/rotational segregation in reg.udral.physics.kinematics and reg.udral.physics.dynamics #130

pavel-kirienko opened this issue Nov 5, 2022 · 1 comment
Assignees
@pavel-kirienko
Labels
enhancement minor new-data-type

Comments

@pavel-kirienko
Copy link
Member

The original intent was to benefit from the strongly typed uavcan.si namespace but the experience indicates that it makes the types more complex with little actual benefit. I propose replacing the segregated translational/rotational types with generalized types that contain native float32-typed fields instead of referring to the uavcan.si namespace.

This change will not affect wire compatibility.
@pavel-kirienko pavel-kirienko self-assigned this Nov 5, 2022
@pavel-kirienko pavel-kirienko mentioned this issue Nov 9, 2022
Closed
@pavel-kirienko
Copy link
Member Author

Superseded by #140

@pavel-kirienko pavel-kirienko closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavel-kirienko pavel-kirienko

Labels
enhancement minor new-data-type
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pavel-kirienko