Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete port name visualization on the Monitor window #296

Closed
PonomarevDA opened this issue Feb 7, 2023 · 4 comments
Closed

Incomplete port name visualization on the Monitor window #296

PonomarevDA opened this issue Feb 7, 2023 · 4 comments

Comments

@PonomarevDA
Copy link

I'm using Yukon for PX4 and Ardupilot. I've added port.List on my custom branch and found out that some of their port names are incompletely visualized in the Monitor window.

Let's study PX4. All port related registers have the following name pattern: uavcan.<pub/sub>.<udral/uorb>.<port name>.<instance number>.id. For example, the ESC related register name is uavcan.pub.udral.esc.0.id. You can check the actual registers names in ParamManager.hpp.

All register names are correctly parsed in the Registers window:
image

In the Monitor window I expect to see uadral.esc.0 . But I see just their instance numbers:
image

All ports which have no dot in their name, it is fine.

Should this problem be solved on the autopilot side by changing the port name pattern (for example by using underscore instead of dots), or can Yukon handle such names?

Thanks.

@silverv
Copy link
Contributor

silverv commented Feb 8, 2023

I programmed it in a way that expects the last element separated by dot to be id, the second last to be the link name and the third last to be the port type (pub/sub/cln/srv).

@pavel-kirienko
Copy link
Member

That is, strictly speaking, up to spec, but then the spec is incorrect:

https://github.com/OpenCyphal/public_regulated_data_types/blob/70573cb98a346f5a9aee54ce421a8a79700df2b4/uavcan/register/384.Access.1.0.dsdl#L128-L139

I think it should be updated to allow the full stop symbol inside the PORT_NAME.

@silverv
Copy link
Contributor

silverv commented Feb 13, 2023

Yes, I will do this.

silverv pushed a commit that referenced this issue Feb 14, 2023
@PonomarevDA
Copy link
Author

Thanks! With the latest release it works well.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants