Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring #1614

Merged
merged 8 commits into from
May 11, 2024
Merged

Small refactoring #1614

merged 8 commits into from
May 11, 2024

Conversation

enyst
Copy link
Collaborator

@enyst enyst commented May 7, 2024

Minimal memory refactoring

  • moving memory code out of the monologue agent, available to be used by all

Also:

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 59.64912% with 23 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@1787a73). Click here to learn what that means.

Files Patch % Lines
opendevin/memory/condenser.py 33.33% 8 Missing ⚠️
opendevin/memory/history.py 60.00% 8 Missing ⚠️
agenthub/monologue_agent/agent.py 57.14% 6 Missing ⚠️
agenthub/micro/agent.py 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1614   +/-   ##
=======================================
  Coverage        ?   63.39%           
=======================================
  Files           ?       99           
  Lines           ?     3958           
  Branches        ?        0           
=======================================
  Hits            ?     2509           
  Misses          ?     1449           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"""

try:
messages = [{'content': summarize_prompt, 'role': 'user'}]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 This helper function looks quite generic except for the logging part. In other words, one can pass any prompt and everything would work even if the function call is a misuse.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good point--maybe the prompt should default to the existing one

@neubig
Copy link
Contributor

neubig commented May 10, 2024

Hey @enyst , looks like this is conflicted now? Happy to take a look if you can update.

@enyst
Copy link
Collaborator Author

enyst commented May 10, 2024

I can fix tomorrow.

@neubig neubig merged commit 98adbf5 into All-Hands-AI:main May 11, 2024
@enyst enyst mentioned this pull request May 14, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants