-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small refactoring #1614
Small refactoring #1614
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
=======================================
Coverage ? 63.39%
=======================================
Files ? 99
Lines ? 3958
Branches ? 0
=======================================
Hits ? 2509
Misses ? 1449
Partials ? 0 ☔ View full report in Codecov by Sentry. |
""" | ||
|
||
try: | ||
messages = [{'content': summarize_prompt, 'role': 'user'}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 This helper function looks quite generic except for the logging part. In other words, one can pass any prompt and everything would work even if the function call is a misuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point--maybe the prompt should default to the existing one
Hey @enyst , looks like this is conflicted now? Happy to take a look if you can update. |
I can fix tomorrow. |
Minimal memory refactoring
Also: