Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: mininit #4

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Conversation

glebm
Copy link

@glebm glebm commented Mar 29, 2020

No description provided.

Copy link
Member

@pcercuei pcercuei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need your signature on the commit too (git commit --amend -s to add it).

#
#############################################################

MININIT_VERSION = 429a1d019a9a1fe5d3662567cd958a54d963e0ff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you short it?
git rev-parse --short 429a1d019a9a1fe5d3662567cd958a54d963e0ff in the mininit repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@glebm
Copy link
Author

glebm commented Mar 31, 2020

I'll need your signature on the commit too (git commit --amend -s to add it).

Done but what's it for?
Does it just add Signed-off-by: Gleb Mazovetskiy <my-email>?

Signed-off-by: Gleb Mazovetskiy <glex.spb@gmail.com>
@pcercuei
Copy link
Member

This is the Developer Certificate of Origin.

@pcercuei pcercuei merged commit f5570c5 into OpenDingux:opendingux Mar 31, 2020
@glebm glebm deleted the add-mininit branch March 31, 2020 01:36
@glebm
Copy link
Author

glebm commented Mar 31, 2020

Ah, got it. Updated all the PRs with this.

pcercuei pushed a commit that referenced this pull request Sep 2, 2020
Add upstream patch (#4) fixing build with gnutls when
BR2_PACKAGE_LIBCURL_PROXY_SUPPORT is disabled.

Patch #4 depends on #3 to apply so add this one as well.

Fixes:
http://autobuild.buildroot.net/results/31d7204869ff71319ea055688c919a646bfb200b/
http://autobuild.buildroot.net/results/f8d2fb919475cdff4a36ad93071048ee09193b98/
http://autobuild.buildroot.net/results/2f07a0ac1240a6040a3509d2ebf06906a31fd172/

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
pcercuei pushed a commit that referenced this pull request Jun 4, 2023
wolfSSL has ARMv8-A assembly implementations of some functions for
both A64 and A32 ISAs.  However, some of the A32 versions use r11,
which is usually not allowed:

wolfcrypt/src/port/arm/armv8-aes.c: In function 'wc_AesCbcEncrypt':
wolfcrypt/src/port/arm/armv8-aes.c:3303:5: error: fp cannot be used in 'asm' here
 3303 |     }
      |     ^

That can be fixed by adding the compiler flag -fomit-frame-pointer,
but then there is another failure:

/tmp/ccV19DQV.s: Assembler messages:
/tmp/ccV19DQV.s:248: Error: first transfer register must be even -- `ldrd r11,r10,[r14,#4*14]'
make[3]: *** [Makefile:5858: wolfcrypt/src/port/arm/src_libwolfssl_la-armv8-chacha.lo] Error 1

This is definitely not a valid instruction in A32, which suggests that
this code isn't being tested at all upstream.  So disable it here.

Fixes:

  http://autobuild.buildroot.net/results/502/502a2b217845eb290c1961d4740b032462f8ae53/

Signed-off-by: Ben Hutchings <ben.hutchings@mind.be>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants