Loading errors from non-core plugins don't appear in the webapp log

[gonzalo-bulnes]

How did you install WebODM?

Docker, but it's not relevant to the issue.

What's your browser and operating system?

Not relevant to the issue.

What is the problem?

What happens

When loading a plugin that is not one of the "core" plugins causes an error, that error is not output to the log. Instead a somewhat generic error is logged, that can also be misleading because it refers to "core" plugins explicitly:

webapp      | WARNING Failed to instantiate plugin example: No module named 'coreplugins.example'

What would be better

webapp      | WARNING Failed to instantiate plugin example: No module named 'coreplugins.example': whatever the error was during previous attempts to load the plugin, if any

Relevant code

• https://github.com/OpenDroneMap/WebODM/blob/v2.3.0/app/plugins/functions.py#L206-L215

How can we reproduce this?

1. Place a plugin in MEDIA_DIR/plugins, say example
2. Make sure that plugin raises some exception, e.g. by adding raise BaseException("something went awfully wrong") in the __init__.py file of the plugin.
3. Restart WebODM
4. Look for Failed to instantiate plugin example: No module named 'coreplugins.example' and observe how nothing around tells you that something went awfully wrong. (Maybe wonder for a bit why coreplugins was involved, but that's a separate topic. 🙂)

Additional context

I came across this when trying to figure out if a cv2 import error was fixed in the context of this forum thread.