Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove glyphicon icons #745

Closed
pierotofy opened this issue Nov 7, 2019 · 10 comments
Closed

Remove glyphicon icons #745

pierotofy opened this issue Nov 7, 2019 · 10 comments
Assignees
Labels
good first issue Issues for first time contributors improvements

Comments

@pierotofy
Copy link
Member

We should remove glyphicons in favor of font-awesome. Currently we use both.

@pierotofy pierotofy added improvements help wanted good first issue Issues for first time contributors labels Nov 7, 2019
@rubb3rDucc
Copy link

Hi there, can I work on this issue?

@pierotofy
Copy link
Member Author

Of course @Mingos1 👍

@rubb3rDucc
Copy link

Currently finishing up, what do I do with a glyphicon without a FA equivalent?

For example, "glyphicon glyphicon-saved" does not have one.

@pierotofy
Copy link
Member Author

pierotofy commented Dec 23, 2020

How about fa fa-check or fa-check-square ?

@rubb3rDucc
Copy link

Thank you, going to add when I start working in a few.

Also, what can I do with the glyphicons integrated as class names?

@pierotofy
Copy link
Member Author

Also, what can I do with the glyphicons integrated as class names?

Can you explain more details? I'm not sure I understood the question. 🙏

@rubb3rDucc
Copy link

No worries. I came across the glyphicons in the button classNames (pictured below) and I was not sure if they could be replaced as the glyphicons within I tags (e.g.,).

Since the glyphicons are apart of bootstrap, I think it would involve removing the over styles ( e.g., btn, btn-primary) and possibly create a conflict.

Essentially, how should I approach this?

question_shot

@pierotofy
Copy link
Member Author

I think it works fine to replace those classes (just keep the btn, btn-primary, etc.):

image

Have you run WebODM in development mode yet?

./webodm.sh start --dev

You can see your changes in real time.

@rubb3rDucc
Copy link

Thanks for the tip; I reread the docs and downloaded Docker, which definitely made the process a lot quicker.

I finished up replacing all of the inline icons. I left all mentions of glyphicons in the stylesheets as is (in case you wanted to revert back to glyphs) and left 1 glyphicon component in (shown below) since I couldn't find a FA equivalent.

I'm going to include this note in the PR, too.

final_q

@Ambial
Copy link

Ambial commented Oct 21, 2021

I guess this issue can be closed?
I found it through https://goodfirstissue.dev/ but it looks like @Mingos1 finished this already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues for first time contributors improvements
Projects
None yet
Development

No branches or pull requests

3 participants