-
-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove glyphicon icons #745
Comments
Hi there, can I work on this issue? |
Of course @Mingos1 👍 |
Currently finishing up, what do I do with a glyphicon without a FA equivalent? For example, "glyphicon glyphicon-saved" does not have one. |
How about |
Thank you, going to add when I start working in a few. Also, what can I do with the glyphicons integrated as class names? |
Can you explain more details? I'm not sure I understood the question. 🙏 |
No worries. I came across the glyphicons in the button classNames (pictured below) and I was not sure if they could be replaced as the glyphicons within I tags (e.g.,). Since the glyphicons are apart of bootstrap, I think it would involve removing the over styles ( e.g., btn, btn-primary) and possibly create a conflict. Essentially, how should I approach this? |
Thanks for the tip; I reread the docs and downloaded Docker, which definitely made the process a lot quicker. I finished up replacing all of the inline icons. I left all mentions of glyphicons in the stylesheets as is (in case you wanted to revert back to glyphs) and left 1 glyphicon component in (shown below) since I couldn't find a FA equivalent. I'm going to include this note in the PR, too. |
I guess this issue can be closed? |
We should remove glyphicons in favor of font-awesome. Currently we use both.
The text was updated successfully, but these errors were encountered: