Merge 101 #12
Merged
Merge 101 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify which transform is needed
Add num_threads flag to allow deterministic computation.
Clang 7 warnings show:
libs/tex/generate_texture_patches.cpp:130:9: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
if (!settings.tone_mapping == TONE_MAPPING_NONE) {
^ ~~
libs/tex/generate_texture_patches.cpp:130:9: note: add parentheses after the '!' to evaluate the comparison first
if (!settings.tone_mapping == TONE_MAPPING_NONE) {
^
( )
libs/tex/generate_texture_patches.cpp:130:9: note: add parentheses around left hand side expression to silence this warning
if (!settings.tone_mapping == TONE_MAPPING_NONE) {
^
( )
`!` binds tigther than `==`, so what was there so far was
`if ((!settings.tone_mapping) == TONE_MAPPING_NONE) {`
which is semantically incorrect.
It is still bug-free currently because only values `0` and `1` in enum
enum ToneMapping {
TONE_MAPPING_NONE = 0,
TONE_MAPPING_GAMMA = 1
};
but as soon as add a third value will be added, this would be wrong.
This commit fixes it by directly checking `TONE_MAPPING_GAMMA` for applying
the `gamma_correct()` function.
Fix technically incorrect comparison in tone mapping.
Fix compile error. The VERSION constant is conflicting with ROS
Use a unique name for another variable
https://bitbucket.org/eigen/eigen had been migrated to https://gitlab.com/libeigen/eigen More Details: http://eigen.tuxfamily.org/index.php?title=News:Migration_to_GitLab.com_scheduled_on_the_December_4th Related issue: OpenDroneMap/ODM#1147
Fetch eigen from GitLab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.