Bar ranges #979
Merged
Bar ranges #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there were multiple meters/groups with different time ranges then when the user selected a subrange that did not include on of the meter/group ranges then it did not honor this on bar. This is now fixed. It now uses all the meters to graph to determine what to do.
|
With more testing I found that when you mix meters and groups then the bars do not align. This is because meters and groups are fetched separately. I'll think about this more but it may be tricky to fix this. |
I've opened issue #980 to address this in the future. It is not planned for v1.0.0 so this PR can go forward. |
|
Am not sure how to reproduce this issue as it's not something I remember seeing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there were multiple meters/groups with different time ranges then when the user selected a subrange that did not include one of the meter/group ranges then it did not honor this on bar. This is now fixed. It now uses all the meters to graph to determine what to do.
Type of change
Checklist
Limitations
None known