Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mathematical expressions #987

Closed
4 tasks done
Ludee opened this issue Jan 12, 2022 · 10 comments · Fixed by #990
Closed
4 tasks done

Add mathematical expressions #987

Ludee opened this issue Jan 12, 2022 · 10 comments · Fixed by #990

Comments

@Ludee
Copy link
Member

Ludee commented Jan 12, 2022

Description of the issue

We want to evaluate on the possibility to add mathematical expressions to classes of the OEO.

Ideas of solution

Workflow checklist

  • I am aware of the workflow for this repository
  • Create a test branch with an example
  • Run tests and break it
  • Document and implement if needed
@Ludee Ludee added enhancement New feature or request To do Issues that haven't got discussed yet ontology infrastructure labels Jan 12, 2022
@Ludee Ludee self-assigned this Jan 12, 2022
@github-actions github-actions bot added this to To do in Issues Jan 12, 2022
@Ludee
Copy link
Member Author

Ludee commented Jan 12, 2022

I created an example document with 4 different latex options:
https://next.rl-institut.de/s/FNKac4DyqQtMBjb

There are two centered and two inline options.
Option 5 would be to only add the formula without the surrounding LaTeX expression.

@l-emele
Copy link
Contributor

l-emele commented Jan 12, 2022

Nice example.

If we want LaTeX, we should avoid option 3 as the $ syntax is pure TeX and not LaTeX.

I like your mentioned option 5 as it is a) shorter and thus easier readable and b) easier for the users to build their own LaTeX arround that as needed.

Regarding your wind energy example: The notation is a bit ambiguous as it can also be interpreted as P= 1/(2 \rho A v^3). Therefore I would rather express this as P=(1/2) \rho A v^3 or P=\frac{1}{2} \rho A v^3.

@Ludee
Copy link
Member Author

Ludee commented Jan 12, 2022

Thanks for the feedback.
I am currently adding a new annotation property called mathematical expression.
I would add this issue as term tracker item and a definition:

The mathematical expression is a property that describes the class with a mathematical formula.

@github-actions github-actions bot moved this from To do to In discussion in Issues Jan 12, 2022
@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Jan 12, 2022
@l-emele
Copy link
Contributor

l-emele commented Jan 13, 2022

I would like to extend the definition a little bit: The mathematical expression is a property that describes the class with a mathematical formula in LaTeX syntax. (Or what ever syntax we finally decide on.) Else it is nowhere documented which syntax should be used.

@stap-m
Copy link
Contributor

stap-m commented Jan 13, 2022

Nice! Just a further slight suggestion:
A mathematical expression is an annotation property that ...

Ludee added a commit that referenced this issue Jan 13, 2022
@Ludee Ludee linked a pull request Jan 13, 2022 that will close this issue
Ludee added a commit that referenced this issue Jan 13, 2022
Ludee added a commit that referenced this issue Jan 13, 2022
Ludee added a commit that referenced this issue Jan 13, 2022
Ludee added a commit that referenced this issue Jan 13, 2022
Ludee added a commit that referenced this issue Jan 13, 2022
Issues automation moved this from In discussion to Done Jan 14, 2022
@Ludee Ludee reopened this Jan 27, 2022
Issues automation moved this from Done to In discussion Jan 27, 2022
@Ludee
Copy link
Member Author

Ludee commented Jan 27, 2022

Looks like there is an issue that breaks the file in Protégée. #997
The underscores are translated with \\.

@Ludee
Copy link
Member Author

Ludee commented Jan 27, 2022

In the OEO-DEV-31 we decided to solve this bug by using camel case for all variables in the expression.
Underscores and backslashes must be avoided.

@l-emele l-emele added this to the oeo-release-1.9.0 milestone Feb 2, 2022
@Ludee
Copy link
Member Author

Ludee commented Feb 10, 2022

I wanted to document the result but wasn't sure where to put it. Should I create a new wiki page?

@l-emele
Copy link
Contributor

l-emele commented Feb 10, 2022

A wiki page is a good idea. You can close then this issue imho with a link to the wiki page.

@Ludee
Copy link
Member Author

Ludee commented Feb 10, 2022

Documentation is in the wiki:
https://github.com/OpenEnergyPlatform/ontology/wiki/Explanation-on-Annotation-Properties

@Ludee Ludee closed this as completed Feb 10, 2022
Issues automation moved this from In discussion to Done Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
LOD-GEOSS
  
Awaiting triage
Issues
  
Done
SIROP
  
Awaiting triage
Development

Successfully merging a pull request may close this issue.

3 participants