Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karatsuba Algorithm C++ #3926

Closed
wants to merge 1 commit into from
Closed

Karatsuba Algorithm C++ #3926

wants to merge 1 commit into from

Conversation

tote93
Copy link
Contributor

@tote93 tote93 commented Jan 16, 2019

Fixes issue:

This program allow to do Karatsuba Multiply Algorithm in C++, developed with standard c++11.

Changes:

@@ -0,0 +1,6 @@
CMAKE_MINIMUM_REQUIRED(VERSION 3.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use CMake in our repository. A build system is unnecessary.

#include <stdlib.h>
#include <time.h>
#include <vector>
#include <math.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmath?

#include <string>
#include <unistd.h>
#include <stdlib.h>
#include <time.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ctime?

#include <fstream>
#include <string>
#include <unistd.h>
#include <stdlib.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cstdlib?

#include "Entero.hpp"


using namespace std;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use this.


using namespace std;

string Entero::operator+(Entero &E)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change all your code to English so most people can understand it?


#include <stdio.h>

#define PLACE(x,y) printf("\033[%d;%dH",x,y) //!< Place
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use these macros. They are unnecessary for this algorithm.

} while (opcion != 0);

return 0;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newlines to end of all your files.

@tote93 tote93 closed this Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants