Fix #4036 : add markdown format for output of stats script #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AdiChat rather than using subheading, the group names looked better as a top level heading, ie:- # HEADING rather than ### HEADING. C. |
arnavb
requested changes
Apr 21, 2019
arnavb
requested changes
Apr 23, 2019
There was a problem hiding this comment.
- As a suggestion, since you are using markdown, you could also use Github emojis to indicate whether something is implemented or not. For example, if an algorithm is implemented, you could use
:white_check_mark:(:white_check_mark:) for an algorithm which has been implemented. For algorithms not implemented, the dot looks fine.
|
@arnavb I like the idea. I think the ✔️ looks better. Have made pr with the change. |
arnavb
requested changes
Apr 25, 2019
arnavb
reviewed
Apr 28, 2019
scripts/stats.py
Outdated
| "sc": "SuperCollider", | ||
| "scala": "Scala", | ||
| "sh": "Shell Script", | ||
| "sml": "Simple Macro Language", |
arnavb
reviewed
Apr 28, 2019
scripts/stats.py
Outdated
| "rkt": "Racket", | ||
| "rs": "Rust", | ||
| "ruby": "Ruby", | ||
| "sc": "SuperCollider", |
There was a problem hiding this comment.
The one file with this extension should be a .scala file. Please fix that in this PR. SuperCollider is an audio format if I researched correctly.
arnavb
reviewed
Apr 28, 2019
| "ex": "Euphoria", | ||
| "exs": "Elixir", | ||
| "f": "Fortran", | ||
| "fs": "Visual F#", |
There was a problem hiding this comment.
Why no Visual for C# but Visual for F# and VB?
arnavb
reviewed
Apr 28, 2019
scripts/stats.py
Outdated
| "cpp": "C++", | ||
| "cr": "CRiSP", | ||
| "cs": "C#", | ||
| "elm": "ELM", |
arnavb
reviewed
Apr 28, 2019
scripts/stats.py
Outdated
| "cs": "C#", | ||
| "elm": "ELM", | ||
| "erl": "Erlang", | ||
| "ex": "Euphoria", |
|
@arnavb have made the changes. See if it can be merged. |
arnavb
reviewed
Apr 28, 2019
AdiChat
approved these changes
Apr 28, 2019
arnavb
approved these changes
Apr 29, 2019
|
@AdiChat Do you think this is ready to merge? |
|
Yes, this looks good 👍 |
|
Looks great 😍 Hope you are enjoying your journey 🚆 with OpenGenus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
fixes #4036
Changes:
To be noted
The markdown file when viewed simply, like a txt file, wouldn't be nicely formatted or anything. Rendering it in browser(say github) or viewing in a markdown viewer would be visually pleasing as promised
How to store output in a file?
python3 scripts/stats.py -f format > location/file_name.formatExample:-
python3 stats.py -f md > ./scripts/STATS.md