Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't load from YouTube #1

Closed
TurnrDev opened this issue Sep 30, 2017 · 5 comments
Closed

Doesn't load from YouTube #1

TurnrDev opened this issue Sep 30, 2017 · 5 comments
Labels
bug

Comments

@TurnrDev
Copy link
Contributor

I run python sum.py -u "https://www.youtube.com/watch?v=ZlXta87qyxU" as suggested in your wiki..
Error I get is..

usage: Watch videos quickly [-h] -i VIDEO_FILE -s SUBTITLES_FILE [-u URL]
Watch videos quickly: error: the following arguments are required: -i/--video-file, -s/--subtitles-file
@AdiChat
Copy link
Member

AdiChat commented Sep 30, 2017

Thanks for pointing out the issue. 👍

The solution is to make the required parameters optional.

@AdiChat AdiChat mentioned this issue Sep 30, 2017
Closed
@AdiChat AdiChat added the bug label Sep 30, 2017
lwgray added a commit to lwgray/vidsum that referenced this issue Oct 1, 2017
@lwgray
fix: Make cmdline ARGS opt and change 'download_url' param
6cbaa4e 
- Requiring video-file and subtitle cmdline args interfere with downloading Youtube videos
- args.video_file is the incorrect parameter to be placed in 'download_url' function call at line 118
Github issue OpenGenus#1
Github issue OpenGenus#2
Github issue OpenGenus#4
This was referenced Oct 1, 2017
Merged
Closed
@TurnrDev
Copy link
Contributor Author

TurnrDev commented Oct 1, 2017

Damn you guys are fast are fixing bugs! Hats off to you! I just pulled the repo but now encountered this:

[jay@desktop-arch code]$ python sum.py -u "https://www.youtube.com/watch?v=ZlXta87qyxU"
  File "sum.py", line 99
    print url
            ^
SyntaxError: Missing parentheses in call to 'print'
py

Made some adjustments #7

@lwgray
Copy link
Contributor

lwgray commented Oct 1, 2017

hi @JayTurnr Sorry, that 'print' statement was left there by accident. Corrected it with PR #8

@shriakhilc
Copy link
Contributor

This issue seems to have been fixed, but it isn't closed. Is there something left to be done?

@TurnrDev
Copy link
Contributor Author

TurnrDev commented Oct 3, 2017

@lwgray I fixed that in PR #7 but nevermind, take the blame.
@TheGamer007 no, sorry I forgot to close

@TurnrDev TurnrDev closed this as completed Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lwgray @AdiChat @TurnrDev @shriakhilc