fix: Make cmdline ARGS optional and change 'download_url' parameter #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Requiring video-file and subtitle cmdline args interfere with downloading Youtube videos - args.video_file is the incorrect parameter to be placed in 'download_url' function call at line 118 Github issue OpenGenus#1 Github issue OpenGenus#2 Github issue OpenGenus#4
|
Looks good. 👍 Hope you enjoy the journey with OpenGenus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
and leads to pyTube DoesNotExist Exception
Fixes
-Delete "required" parameter from commandline argument definitions
-Change download_url parameter from args.video_file to the 'url' variable
Closes:
Github issue #1
Github issue #2
Github issue #4