Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MarshallableReaderWriter combined with writeDefault=false may cause retrieving empty values from the map #345

Closed
glukos opened this issue Sep 29, 2021 · 2 comments
Closed

MarshallableReaderWriter combined with writeDefault=false may cause retrieving empty values from the map #345

glukos opened this issue Sep 29, 2021 · 2 comments
Assignees
@glukos

Comments

@glukos
Copy link
Contributor

glukos commented Sep 29, 2021 •
edited

Test - MarshallableReaderWriterTest

The root cause is Wires#WIRE_TL - saved position (that's left after handling unexpected fields) may be set in its ValueInState. As a result we may restore the saved position and skip some of contents during unmarshalling.
@glukos glukos self-assigned this Sep 29, 2021
glukos added a commit that referenced this issue Sep 29, 2021
@glukos
Fix retrieving empty values with MarshallableReaderWriter, closes #345
419a745
@nicktindall
Copy link
Contributor

Interestingly I found this same problem in DocumentContext OpenHFT/Chronicle-Wire#311. Might be something to look out for elsewhere when Wires are reused.

JerryShea pushed a commit to OpenHFT/Chronicle-Wire that referenced this issue Sep 29, 2021
@glukos @JerryShea
Fix retrieving empty values with MarshallableReaderWriter, closes Ope…
794929d 
…nHFT/Chronicle-Map#345
@hft-team-city
Copy link
Contributor

Released in Chronicle-Map-3.22ea4, BOM-2.22ea29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glukos glukos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicktindall @glukos @hft-team-city