Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

ConnectionListener#onDisconnected is called twice for every disconnect #164

Closed
nicktindall opened this issue Dec 2, 2021 · 3 comments · Fixed by #185
Closed

ConnectionListener#onDisconnected is called twice for every disconnect #164

nicktindall opened this issue Dec 2, 2021 · 3 comments · Fixed by #185
Assignees
@nicktindall @jkolobok

Comments

@nicktindall
Copy link
Contributor

(when using the UberHandler at least)

It's called here

Chronicle-Network/src/main/java/net/openhft/chronicle/network/cluster/handlers/UberHandler.java

Line 157 in 5d53d32

listener.onDisconnected(localIdentifier, remoteIdentifier(), nc.isAcceptor());

and here

Chronicle-Network/src/main/java/net/openhft/chronicle/network/cluster/handlers/HeartbeatHandler.java

Lines 227 to 228 in 5d53d32

connectionMonitor.onDisconnected(HeartbeatHandler.this.localIdentifier(),
HeartbeatHandler.this.remoteIdentifier(), HeartbeatHandler.this.nc().isAcceptor());

jkolobok added a commit that referenced this issue Apr 24, 2022
@jkolobok
#164 ConnectionListener#onDisconnected_is_called_twice_for_every_disc…
308c4c9 
…onnect
@jkolobok jkolobok linked a pull request Apr 24, 2022 that will close this issue
#164 ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect #185
Merged
jkolobok added a commit that referenced this issue Apr 25, 2022
@jkolobok
#164 ConnectionListener#onDisconnected_is_called_twice_for_every_disc…
f879392 
…onnect. moved exception handler
@JerryShea JerryShea mentioned this issue Oct 26, 2022
Closed
JerryShea pushed a commit that referenced this issue Oct 27, 2022
@jkolobok @JerryShea
#164 ConnectionListener#onDisconnected_is_called_twice_for_every_disc…
4c8a27e 
…onnect
JerryShea pushed a commit that referenced this issue Oct 27, 2022
@jkolobok @JerryShea
#164 ConnectionListener#onDisconnected_is_called_twice_for_every_disc…
d1b0c4f 
…onnect. moved exception handler
nicktindall pushed a commit that referenced this issue Oct 27, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
15b67b5 
Fixes #164

- ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect. moved exception handler
- Add tests for #164
nicktindall pushed a commit that referenced this issue Oct 27, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
bf98ac2 
Fixes #164

- moved exception handler
- Add tests
nicktindall pushed a commit that referenced this issue Oct 27, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
0fb6c88 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
nicktindall pushed a commit that referenced this issue Oct 27, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
85fc440 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
d924be6 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
f80e3a0 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
- Tolerate null ConnectionListener
nicktindall added a commit to OpenHFT/OpenHFT that referenced this issue Oct 28, 2022
@nicktindall
Bump network for OpenHFT/Chronicle-Network#164 and OpenHFT/Chronicle-…
a7584b4 
…Network#219
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
12e49cc 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
- Tolerate null ConnectionListener
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
78d31ac 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
- Tolerate null ConnectionListener
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
0a9499f 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
- Tolerate null ConnectionListener
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
0c5aa3f 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
- Tolerate null ConnectionListener
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
d151ae5 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
- Tolerate null ConnectionListener
@hft-team-city
Copy link
Collaborator

Released in Chronicle-Network-2.24ea2, BOM-2.24ea6

@hft-team-city
Copy link
Collaborator

Released in Chronicle-Network-2.23.23, BOM-2.23.131

@hft-team-city
Copy link
Collaborator

Released in Chronicle-Network-2.22.16, BOM-2.22.165

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nicktindall nicktindall

@jkolobok jkolobok

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nicktindall @jkolobok @hft-team-city