Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

UberHandler heartbeat timeout being reset on send OR receive #219

Closed
nicktindall opened this issue Oct 27, 2022 · 3 comments
Closed

UberHandler heartbeat timeout being reset on send OR receive #219

nicktindall opened this issue Oct 27, 2022 · 3 comments

Comments

@nicktindall
Copy link
Contributor

The timeout in the UberHandler's HeartbeatHandler is being reset on every send OR receive. So it effectively never triggers. As long as you're sending heartbeats, it won't time-out, even if it's not receiving any from the other side:

Chronicle-Network/src/main/java/net/openhft/chronicle/network/cluster/handlers/UberHandler.java

Lines 289 to 293 in 7d76645

private void onMessageReceivedOrWritten() {
final HeartbeatEventHandler heartbeatEventHandler = heartbeatEventHandler();
if (heartbeatEventHandler != null)
heartbeatEventHandler.onMessageReceived();
}

@nicktindall nicktindall changed the title HearbeatHandler timeout being reset on send OR receive UberHandler heartbeat timeout being reset on send OR receive Oct 27, 2022
nicktindall pushed a commit that referenced this issue Oct 27, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
0fb6c88 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
nicktindall pushed a commit that referenced this issue Oct 27, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
85fc440 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
d924be6 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
f80e3a0 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
- Tolerate null ConnectionListener
nicktindall added a commit to OpenHFT/OpenHFT that referenced this issue Oct 28, 2022
@nicktindall
Bump network for OpenHFT/Chronicle-Network#164 and OpenHFT/Chronicle-…
a7584b4 
…Network#219
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
12e49cc 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
- Tolerate null ConnectionListener
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
78d31ac 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
- Tolerate null ConnectionListener
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
0a9499f 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
- Tolerate null ConnectionListener
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
0c5aa3f 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
- Tolerate null ConnectionListener
nicktindall pushed a commit that referenced this issue Oct 28, 2022
@jkolobok @nicktindall
ConnectionListener#onDisconnected_is_called_twice_for_every_disconnect,
d151ae5 
Fixes #164 & Fixes #219

- moved exception handler
- Add tests
- Don't reset HeartbeatHandler timeout on message send
- Tolerate null ConnectionListener
@hft-team-city
Copy link
Collaborator

Released in Chronicle-Network-2.24ea2, BOM-2.24ea6

@hft-team-city
Copy link
Collaborator

Released in Chronicle-Network-2.23.23, BOM-2.23.131

@hft-team-city
Copy link
Collaborator

Released in Chronicle-Network-2.22.16, BOM-2.22.165

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicktindall @hft-team-city