Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for reading an object with list field #894 #895

Closed
wants to merge 1 commit into from

Conversation

alamar
Copy link
Contributor

@alamar alamar commented May 16, 2024

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alamar
Copy link
Contributor Author

alamar commented May 24, 2024

Breakpoint reached
	at net.openhft.chronicle.wire.BinaryWire$BinaryValueIn.sequence(BinaryWire.java:4125)
	at net.openhft.chronicle.wire.Wires.objectSequence(Wires.java:1013)
	at net.openhft.chronicle.wire.Wires.object2(Wires.java:1217)
	at net.openhft.chronicle.wire.Wires.object1(Wires.java:1157)
	at net.openhft.chronicle.wire.ValueIn.object(ValueIn.java:1282)
	at net.openhft.chronicle.wire.WireMarshaller$ObjectFieldAccess.setValue(WireMarshaller.java:1435)
	at net.openhft.chronicle.wire.WireMarshaller$FieldAccess.readValue(WireMarshaller.java:1251)
	at net.openhft.chronicle.wire.WireMarshaller.readMarshallableDTOOrder(WireMarshaller.java:515)
	at net.openhft.chronicle.wire.WireMarshaller.readMarshallable(WireMarshaller.java:488)
	at net.openhft.chronicle.wire.Wires.readMarshallable(Wires.java:741)
	at net.openhft.chronicle.wire.SerializationStrategies$6.readUsing(SerializationStrategies.java:317)
	at net.openhft.chronicle.wire.BinaryWire$BinaryValueIn.marshallable(BinaryWire.java:4546)
	at net.openhft.chronicle.wire.Wires.objectMap(Wires.java:1052)
	at net.openhft.chronicle.wire.Wires.object2(Wires.java:1214)
	at net.openhft.chronicle.wire.ValueIn.object(ValueIn.java:1266)
	at net.openhft.chronicle.wire.MethodReaderArgumentsRecycleTestMethodReaderArgumentsRecycleTest$1MethodReader.readOneGenerated(MethodReaderArgumentsRecycleTestMethodReaderArgumentsRecycleTest$1MethodReader.java:136)

Sadly it is completely not clear where the collection clearing should take place. If the field type changes to List then it is done by collection field access subclass.

@alamar alamar assigned alamar and tgd and unassigned alamar Jun 3, 2024
@alamar alamar closed this Jun 25, 2024
@alamar alamar deleted the Wire894-test branch June 25, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants