Clean-up and reimplementation of PowerFactory solar models #266

tinrabuzin · 2021-01-09T12:30:47Z

Not all functionality is implemented and not all models are checked yet, but at least the models are usable now.

tinrabuzin · 2021-01-09T14:17:42Z

5c30fa1 removes the need for fixing graphics from #265

dietmarw

I have not yet looked at the models themselves but noticed that the hierarchy is off. PowerFactory is a product of the company named DigSILENT. Now why would you have a subfolder DigSILENT inside PowerFactory? That is the wrong way round. Anyway it would be sufficient to only name the software and not the company. We also don't do Siemens/PSSE. So please fix the structure.

tinrabuzin · 2021-01-25T08:56:01Z

I have not yet looked at the models themselves but noticed that the hierarchy is off. PowerFactory is a product of the company named DigSILENT. Now why would you have a subfolder DigSILENT inside PowerFactory? That is the wrong way round. Anyway it would be sufficient to only name the software and not the company. We also don't do Siemens/PSSE. So please fix the structure.

The hierarchy is not off, it's like that on purpose. If you check the structure of the models in the PowerFactory itself, they have implemented various models. Specifically for the PV models you can find that they've implemented their own version of a solar panel and the WECC models of solar panels like it's shown below.

If you look further you can see the other dynamic models are structured similarly, including the folder for PSSE which you mention.

Wrong understanding of the structure

dietmarw · 2021-01-25T11:49:01Z

OK I see. In that case it does make sense. So basically DIgSILENT have still not come to terms with their own rebranding of their product.

tinrabuzin · 2021-01-25T13:46:18Z

Where now stands DigSILENT, there was once KTH. :)

dietmarw · 2021-01-25T13:48:56Z

Only it should be DIgSILENT

dietmarw · 2021-01-28T14:57:23Z

OpenIPSL/Electrical/Solar/PowerFactory/DIgSILENT/Auxiliary/ActivePowerController.mo

@@ -0,0 +1,114 @@
+within OpenIPSL.Electrical.Solar.PowerFactory.DIgSILENT.Auxiliary;
+
+model ActivePowerController


Please add a short descriptive string to this and also to all the other models which are added.

Done in fa63456.

dietmarw

Some things need fixing:

Still some typos of DIgSILENT present
Use Types.* instead of SI.* and the latter only if not present under Types.*
remove local imports of SI and C. Those imports are already present on the top-level and don't need to get repeated.
input/output connectors need to be arranged on the grid as such that they don't cause steps when connecting (i.e., multiple of 40 on the icon layer). Also check the MSL conventions for good style icon layout: Modelica.UsersGuide.Conventions.Icons
align blocks and connections on the grid, do not use streched icons (See Solar.PowerFactory.DIgSILENT.PV_Plant for a bad example)
avoid counters as part of instance names if only one instance is present

tinrabuzin · 2021-01-28T15:25:02Z

avoid counters as part of instance names if only one instance is present

By this you mean all the blocks from MSL? Otherwise I can't see where they happened.

dietmarw · 2021-01-28T15:38:03Z

By this you mean all the blocks from MSL? Otherwise I can't see where they happened.

One example would be OpenIPSL.Electrical.Solar.PowerFactory.DIgSILENT.DCBusBar with only one add block present but it is called add1.

tinrabuzin · 2021-01-28T17:02:49Z

@dietmarw Hopefully all of the things you've listed have now been fixed.

marcelofcastro · 2021-02-04T14:27:01Z

OpenIPSL/Examples/Solar/PowerFactory/DIgSILENT_PV.mo

+    Placement(visible = true, transformation(origin = {70, 30}, extent = {{10, -10}, {-10, 10}}, rotation = 0)));
+  inner OpenIPSL.Electrical.SystemBase SysData annotation(
+    Placement(visible = true, transformation(origin = {-70.5, 90}, extent = {{-29.5, -10}, {29.5, 10}}, rotation = 0)));
+  OpenIPSL.Electrical.Solar.PowerFactory.DIgSILENT.PV_Plant pv_plant(M_b(displayUnit = "V.A") = 0.5e6, P_0 = 300000, angle_0 = 0, v_0 = 1)  annotation(


is it V.A or VA here after displayUnit? @tinrabuzin

@marcelofcastro That's what OpenModelica picks up from MSL. It was not me. :)

cool cool, just wanted to make sure it was not a typo haha

It does look like it so I went and checked. The unit abbreviation does not make sense if you ask me but maybe there's something that I don't know...

maybe the dot is just to make the multiplication of units explicit. It's a bit weird to me as well but @dietmarw will say that I may have a problem with units in Modelica hahaha Anyway, good that's not a typo!

It should be VA. I guess some version of OMEdit did screw this up. I changed it now to a more meaningful MVA

OpenIPSL/Electrical/Solar/PowerFactory/DIgSILENT/PV_Plant.mo

marcelofcastro · 2021-02-04T15:03:55Z

OpenIPSL/Electrical/Solar/PowerFactory/DIgSILENT/PV_Plant.mo

+<td><p>This model has not been verified against PowerFactory.</p></td>
+</tr>
+<tr>
+<td><p>Description</p></td>


Since there's no description, you can remove this row and this is valid for every model you have here in this PR.

Ok. Done in 7d764f2.

marcelofcastro · 2021-02-04T15:09:38Z

OpenIPSL/Electrical/Solar/PowerFactory/DIgSILENT/PV_Plant.mo

+</p>
+</html>", revisions = "<html>
+<table cellspacing=\"1\" cellpadding=\"1\" border=\"1\"><tr>
+<td><p>Model Name</p></td>


I am not sure we need this Model Name row as well. But I will leave it to @dietmarw

@marcelofcastro @tinrabuzin I guess the model name here is meant as reference back to what it is called in PowerFactory. So maybe still of use.

Oh okay, so we can use it for sure.

marcelofcastro · 2021-02-04T15:15:14Z

OpenIPSL/Examples/Solar/PowerFactory/DIgSILENT_PV.mo

+  connect(voltage_source.f0, frequency.y) annotation(
+    Line(points = {{40, 4}, {50, 4}, {50, 30}, {60, 30}}, color = {0, 0, 127}));
+protected
+  annotation(


I think it would be nice to include here what the user should see when executing this example. For instance, take a look at Examples.Controls.PSSE.TG.GGOV1, there we started implementing this idea of listing what the user should see when simulating the model. It can be super brief but it helps to have an idea of what is being simulated.

Good idea. Check out 6f41a4f.

yeah, it's pretty nice now!

dietmarw · 2022-01-18T10:18:40Z

Given the delay of 2.0.0 I would not be against including this and #267 in the final 2.0.0 release. @marcelofcastro @lvanfretti, any thoughts?

marcelofcastro · 2022-01-18T18:10:41Z

Given the delay of 2.0.0 I would not be against including this and #267 in the final 2.0.0 release. @marcelofcastro @lvanfretti, any thoughts?

I agree, @dietmarw. Let's include these changes in 2.0.0.

… models

Co-authored-by: Marcelo de C. Fernandes <decasm3@rpi.edu>

Still contains the original code that

dietmarw · 2022-01-20T13:04:35Z

I needed to change the x connector in ActivePowerConverter to be of output type. Otherwise the model is not structurally correct. With that and some minor clean up fixes this PR can finally be merged.

tinrabuzin added the enhancement label Jan 9, 2021

tinrabuzin added this to the 2.1 milestone Jan 9, 2021

tinrabuzin requested a review from dietmarw January 9, 2021 12:30

tinrabuzin mentioned this pull request Jan 9, 2021

Adding PowerFactory implementation of distributed solar PVD1 #267

Open

dietmarw previously requested changes Jan 25, 2021

View reviewed changes

dietmarw reviewed Jan 28, 2021

View reviewed changes

dietmarw requested changes Jan 28, 2021

View reviewed changes

dietmarw mentioned this pull request Jan 28, 2021

Changes to ULTC and correct syntax fixes for OCT #265

Merged

marcelofcastro requested a review from dietmarw February 4, 2021 14:18

marcelofcastro reviewed Feb 4, 2021

View reviewed changes

OpenIPSL/Electrical/Solar/PowerFactory/DIgSILENT/PV_Plant.mo Outdated Show resolved Hide resolved

marcelofcastro reviewed Feb 4, 2021

View reviewed changes

OpenIPSL/Electrical/Solar/PowerFactory/DIgSILENT/PV_Plant.mo Outdated Show resolved Hide resolved

marcelofcastro reviewed Feb 4, 2021

View reviewed changes

dietmarw force-pushed the solar_models branch 2 times, most recently from 78de773 to 303ab10 Compare May 21, 2021 13:48

dietmarw force-pushed the solar_models branch from 4c42ca8 to b1ef94e Compare May 31, 2021 09:37

dietmarw removed this from the 2.1.0 milestone Jan 19, 2022

Tin Rabuzin and others added 24 commits January 20, 2022 11:04

Working PV Plant with models implemented so far

abc7b36

A small working example of the PV plant use

560b738

The deleted examples were not PSAT but incorrect and old PowerFactory…

c632444

… models

Fixing a package name typo and removing leftovers from stone age

973cc6f

Adding descriptive strings

f4e86a9

Changing from SI to types

67aafd9

Removing unnecessary imports

44e1d88

Renaming instances and removing forgoten models in the example

3091227

Hopefully catching the last DIgSILENT typos

7cda6f8

Overhaul of the diagrams and icons

b3773bf

Update OpenIPSL/Electrical/Solar/PowerFactory/DIgSILENT/PV_Plant.mo

b832ce4

Co-authored-by: Marcelo de C. Fernandes <decasm3@rpi.edu>

Update OpenIPSL/Electrical/Solar/PowerFactory/DIgSILENT/PV_Plant.mo

00ea496

Co-authored-by: Marcelo de C. Fernandes <decasm3@rpi.edu>

Fixing annotations, removing desc. rows, fixing the author reference

229402a

Adding the example description

abf1496

Removing the extra code HTML tag

70a6d85

More HTML fixes

296d7d9

Missing tags fixes

0c60420

Draft of the improved PVModule with conditional components.

00ffb2d

Still contains the original code that

Removing the my old code in the comments

89211e4

Fix the display unit.

afa4d67

Use slash instead of backslash

e2e7e2c

Use proper °C

71a55ac

Don't misuse the gitignore in order to populate the repo with old files.

8ecc2d5

Fixing all icons.

59ba050

dietmarw force-pushed the solar_models branch from b334ed1 to 59ba050 Compare January 20, 2022 10:05

Fix the ActivePowerController by making x an output

a73abfd

dietmarw approved these changes Jan 20, 2022

View reviewed changes

dietmarw merged commit a867ba3 into OpenIPSL:master Jan 20, 2022

dietmarw mentioned this pull request Nov 4, 2022

Connect on non-connectors #317

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean-up and reimplementation of PowerFactory solar models #266

Clean-up and reimplementation of PowerFactory solar models #266

tinrabuzin commented Jan 9, 2021

tinrabuzin commented Jan 9, 2021 •

edited

dietmarw left a comment •

edited

tinrabuzin commented Jan 25, 2021 •

edited

dietmarw commented Jan 25, 2021

tinrabuzin commented Jan 25, 2021

dietmarw commented Jan 25, 2021

dietmarw Jan 28, 2021

tinrabuzin Jan 28, 2021

dietmarw left a comment

tinrabuzin commented Jan 28, 2021

dietmarw commented Jan 28, 2021

tinrabuzin commented Jan 28, 2021

marcelofcastro Feb 4, 2021

tinrabuzin Feb 4, 2021

marcelofcastro Feb 4, 2021

tinrabuzin Feb 4, 2021

marcelofcastro Feb 4, 2021

dietmarw Jan 20, 2022

marcelofcastro Feb 4, 2021

tinrabuzin Feb 4, 2021

marcelofcastro Feb 4, 2021

marcelofcastro Feb 4, 2021

dietmarw Jan 18, 2022

marcelofcastro Jan 18, 2022

marcelofcastro Feb 4, 2021

tinrabuzin Feb 4, 2021

marcelofcastro Feb 4, 2021

dietmarw commented Jan 18, 2022

marcelofcastro commented Jan 18, 2022

dietmarw commented Jan 20, 2022

		@@ -0,0 +1,114 @@
		within OpenIPSL.Electrical.Solar.PowerFactory.DIgSILENT.Auxiliary;

		model ActivePowerController

Clean-up and reimplementation of PowerFactory solar models #266

Clean-up and reimplementation of PowerFactory solar models #266

Conversation

tinrabuzin commented Jan 9, 2021

tinrabuzin commented Jan 9, 2021 • edited

dietmarw left a comment • edited

Choose a reason for hiding this comment

tinrabuzin commented Jan 25, 2021 • edited

dietmarw commented Jan 25, 2021

tinrabuzin commented Jan 25, 2021

dietmarw commented Jan 25, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dietmarw left a comment

Choose a reason for hiding this comment

tinrabuzin commented Jan 28, 2021

dietmarw commented Jan 28, 2021

tinrabuzin commented Jan 28, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dietmarw commented Jan 18, 2022

marcelofcastro commented Jan 18, 2022

dietmarw commented Jan 20, 2022

tinrabuzin commented Jan 9, 2021 •

edited

dietmarw left a comment •

edited

tinrabuzin commented Jan 25, 2021 •

edited