Adding PowerFactory implementation of distributed solar PVD1 #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dietmarw
requested changes
Jan 20, 2022
There was a problem hiding this comment.
I have now rebased this extension onto master (with the now merged #266). However, this extension has still a number of issues:
- structural problems in
StaVmeasdue to conditional inputs not implemented correctly - missing description strings in all the models
- missing documentation of the models
- untidy diagrams
@tinrabuzin could you have a look otherwise we have to postpone this merge to the future.
|
BTW, I had to squash and rebase, so when working on this do a hard reset of your checkout branch. |
I don't have any time right now to fix this, sorry. Eventually, I will look into it. |
|
@tinrabuzin That is fine. Since these are additional models there is no rush. So I'm gonna reassign the milestone again for the next release. |
|
This PR is now rebased onto the latest v3.1.0-dev master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably be merged after #266.