Fix Getting Dimmer Max Value

[kecramer]

Dimmer max is a single 16 bit value, not an 8 bit.

[kecramer]

This is failing make check for me locally but so is master, and I believe it unrelated to this code.

[peternewman]

One comment.

What's the error you get with make check?

[kecramer]

common/utils/DmxBufferTest.cpp:197:10: error: explicitly assigning value of
      variable of type 'ola::DmxBuffer' to itself
      [-Werror,-Wself-assign-overloaded]
  buffer = buffer;
  ~~~~~~ ^ ~~~~~~
1 error generated.

Is the error when I am up to date with origin/master (and for this branch as well)

[peternewman]

Hi @kecramer ,

Looking at this a bit more, please can you make a GenericGet and Handle equivalent to GenericGetU32/_HandleU32Response for U16 and change this and GetDMXAddress to use it please.

It, and the GetU8 and U32 variants should also all have the CheckCallback line:

 if (CheckCallback(error, callback))
   return false;

[peternewman]

Thanks @kecramer . Sorry I missed it before, but could you switch SetDMXAddress to use the new GenericSetU16 you've very sensibly added.

[kecramer]

Ah good point, definitely missed that one. Let me know if you have any other comments.

[peternewman]

Ah good point, definitely missed that one. Let me know if you have any other comments.

Well in fairness I didn't initially suggest even making a generic set as I'd missed the fact the brightness would have a set too.

[peternewman]

LGTM, thanks for this bugfix and the related tidying.