Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UART DMX plugin on Bullseye and more recent Linux distributions #1760

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Fix UART DMX plugin on Bullseye and more recent Linux distributions #1760

merged 3 commits into from
Jan 13, 2022

Conversation

peternewman
Copy link
Member

Essentially just include a different combination of headers, but add some required cotton wool around this.

Closes #1749

With huge thanks to @plugz for mcallegari/qlcplus@5116d98

peternewman and others added 2 commits December 29, 2021 22:01
@peternewman
Merge pull request #34 from OpenLightingProject/0.10
1623df7 
Resync with 0.10
@peternewman
Fix UART DMX plugin on Bullseye and more recent Linux distributions
8f25081 
Essentially just include a different combination of headers, but add some required cotton wool around this.

Closes OpenLightingProject#1749

With huge thanks to @plugz for mcallegari/qlcplus@5116d98
@peternewman peternewman added this to the 0.10.9 milestone Dec 30, 2021
@peternewman peternewman linked an issue Dec 30, 2021 that may be closed by this pull request
Uarts on RPi4 stopped working (Bullseye & ola 0.10.8) #1749
Closed
@peternewman peternewman mentioned this pull request Dec 30, 2021
Closed
@peternewman
Copy link
Member Author

Also @shenghaoyang was there in #1750 (comment) but it wasn't immediately obvious because our existing asm/termios.h include stuff wasn't in there example.

@peternewman peternewman mentioned this pull request Dec 30, 2021
Closed
@peternewman peternewman linked an issue Jan 11, 2022 that may be closed by this pull request
UART on Pi Issues #1665
Closed
@peternewman peternewman mentioned this pull request Jan 11, 2022
Closed
@peternewman peternewman merged commit ad6a17b into OpenLightingProject:0.10 Jan 13, 2022
@gnosis953
Copy link

Sorry, might be a simple mistake. But i get error: "aminclude.am:35 ***Missing seperator. stop"

when executing make operation.

Also i had to rename the following files:
Makefile.am => Makefile.in
./java/Makefile.am => Makefile.in

because ./configure said it could not finde the two files.

Thank
you in Advance

@peternewman
Copy link
Member Author

Sorry, might be a simple mistake. But i get error: "aminclude.am:35 ***Missing seperator. stop"
Also i had to rename the following files: Makefile.am => Makefile.in ./java/Makefile.am => Makefile.in

Yes it is simple thankfully, you need to run autoreconf -i first to make those files if you've sourced the code from Git.

Next time you'd be better off opening an issues about something like this.

@gnosis953
Copy link

I used autoreconf bevor.

Seemed to be another mistake. I pulled the merge and it worked.

@pete111 pete111 mentioned this pull request Jul 21, 2023
Open
@milksteakjellybeans milksteakjellybeans mentioned this pull request Sep 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Maintainability
Projects
None yet
Milestone
0.10.9
Development

Successfully merging this pull request may close these issues.

Uarts on RPi4 stopped working (Bullseye & ola 0.10.8) UART on Pi Issues
2 participants
@peternewman @gnosis953