Add the Anyma, Eurolite and Fadecandy widgets. #543
Conversation
| * along with this program; if not, write to the Free Software | ||
| * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * AnymauDMX.cpp |
There was a problem hiding this comment.
Firstly, personally I'm still in favour of the files just being manufacturer, rather than manufacturer-device.
Regardless of that, this file doesn't match the Camel Case style we're using elsewhere, and just looks a bit odd to me. I wonder if it should be AnymaUDmx.cpp?
There was a problem hiding this comment.
The actual name of the device is uDMX.
There was a problem hiding this comment.
Yep, but we don't stick to that with include/ola/DmxBuffer.h; although we're not very consistent looking at include/ola/http/HTTPServer.h.
There was a problem hiding this comment.
Yeah. I standardized on 'DMX' for the client code but DmxBuffer predates that. I'd prefer to use DMX going forward.
|
Looks good aside from comments. I need to test that your Fadecandy code works. |
Add the Anyma, Eurolite and Fadecandy widgets.
No description provided.