-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Fadecandy board; closes #503 #512
Conversation
class ScanlimeDevice: public UsbDevice { | ||
public: | ||
ScanlimeDevice(ola::AbstractPlugin *owner, | ||
libusb_device *usb_device, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dedent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Please remember to add this to http://www.openlighting.org/ola/ |
Doh, carefully did all the edits manually initially, then decided I should call it the manufacturer (scanlime), rather than the product (Fadecandy) to match the others... |
…ff as channel 1 changes
…and fix some other bugs, like not working if replugged while transmitting; whereas fcserver does.
Still needs LUT fixing, and recovery if replugged while transmitting. Fcserver seems to recover from this, but we don't, even if olad is stopped and started, so they're obviously initialising the Fadecandy properly in a way we're not. For future stuff, multiple ports, to support all the data possible, RDM support for config/patching. |
Are you done with changing this? If so I'll pull the changes into the new hotplug version. |
I've probably stopped changing the bulk of it, some minor tweaks of packet generation code perhaps, but they should be easy enough to port in later. I'll do more significant bits later on. |
You can close this one now :) |
Does it support more than 170 pixels? Can I have multiple FadeCandy boards connected? |
Not yet. |
Not more than 1 board either? |
Not more than 170 pixels per board @HakanL, adding the code to send more is easy enough, the problem is dealing with the sync of potentially multiple universes and only one output. Multiple boards should just work, with 170 pixels per board, however I've only got access to one board, so haven't tested this. I have confirmed that stuff maps across the ports correctly though. |
Sounds good. I'm receiving 3 FadeCandy boards this week so I should be able to test it. |
@HakanL can you start a topic on the mailing list https://groups.google.com/forum/#!forum/open-lighting as that's a more appropriate place to discuss this than an unrelated PR. |
Oh and http://www.openlighting.org/ola/ updated. |
No where near merge yet, and nothing functional, just to let Travis do it's thing.