Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Fadecandy board; closes #503 #512

Closed
wants to merge 9 commits into from

Conversation

peternewman
Copy link
Member

No where near merge yet, and nothing functional, just to let Travis do it's thing.

class ScanlimeDevice: public UsbDevice {
public:
ScanlimeDevice(ola::AbstractPlugin *owner,
libusb_device *usb_device,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dedent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@nomis52
Copy link
Member

nomis52 commented Nov 7, 2014

Please remember to add this to http://www.openlighting.org/ola/

@peternewman
Copy link
Member Author

Doh, carefully did all the edits manually initially, then decided I should call it the manufacturer (scanlime), rather than the product (Fadecandy) to match the others...

@peternewman
Copy link
Member Author

Still needs LUT fixing, and recovery if replugged while transmitting. Fcserver seems to recover from this, but we don't, even if olad is stopped and started, so they're obviously initialising the Fadecandy properly in a way we're not.

For future stuff, multiple ports, to support all the data possible, RDM support for config/patching.

@nomis52
Copy link
Member

nomis52 commented Nov 19, 2014

Are you done with changing this? If so I'll pull the changes into the new hotplug version.

@peternewman
Copy link
Member Author

I've probably stopped changing the bulk of it, some minor tweaks of packet generation code perhaps, but they should be easy enough to port in later. I'll do more significant bits later on.

@nomis52
Copy link
Member

nomis52 commented Nov 29, 2014

You can close this one now :)

@HakanL
Copy link
Contributor

HakanL commented Dec 1, 2014

Does it support more than 170 pixels? Can I have multiple FadeCandy boards connected?

@nomis52
Copy link
Member

nomis52 commented Dec 1, 2014

Not yet.

@HakanL
Copy link
Contributor

HakanL commented Dec 1, 2014

Not more than 1 board either?

@peternewman
Copy link
Member Author

Not more than 170 pixels per board @HakanL, adding the code to send more is easy enough, the problem is dealing with the sync of potentially multiple universes and only one output.

Multiple boards should just work, with 170 pixels per board, however I've only got access to one board, so haven't tested this. I have confirmed that stuff maps across the ports correctly though.

@HakanL
Copy link
Contributor

HakanL commented Dec 1, 2014

Sounds good. I'm receiving 3 FadeCandy boards this week so I should be able to test it.

@peternewman
Copy link
Member Author

@HakanL can you start a topic on the mailing list https://groups.google.com/forum/#!forum/open-lighting as that's a more appropriate place to discuss this than an unrelated PR.

@peternewman
Copy link
Member Author

Closing this without merging as @nomis52 re-implemented the code in #543. #503 tracks the odd outstanding issues/feature requests.

@peternewman peternewman closed this Dec 7, 2014
@peternewman
Copy link
Member Author

Oh and http://www.openlighting.org/ola/ updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants