Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fixtures that are only controllable via dimmer pack #694

Open
FloEdelmann opened this issue Nov 27, 2018 · 3 comments
Open

Support fixtures that are only controllable via dimmer pack #694

FloEdelmann opened this issue Nov 27, 2018 · 3 comments
Labels
component-fixture Affects one or more existing fixture definitions. component-schema Affects the fixture JSON schema.

Comments

@FloEdelmann
Copy link
Member

FloEdelmann commented Nov 27, 2018

Add a new fixture category "No DMX" (or similar) to fixtures that are only controllable via dimmer pack, namely the ADB Europe 105 and the Robert Juliat 613SX (as of now).

That category could trigger showing a special warning on the fixture page. The fixture test should enforce that fixtures with that category only contain one-channel modes (since everything else would not be possible via a dimmer pack).

@FloEdelmann FloEdelmann added component-fixture Affects one or more existing fixture definitions. component-schema Affects the fixture JSON schema. labels Nov 27, 2018
@peternewman
Copy link
Member

That category could trigger showing a special warning on the fixture page. The fixture test should enforce that fixtures with that category only contain one-channel modes (since everything else would not be possible via a dimmer pack).

They won't all only be one channel, see for example this:
https://hire.hawthorn.biz/catalogue/product.aspx?id=10674

Although I'm not personally convinced of the benefit of adding every tungsten fixture to your library.

@kengruven
Copy link
Contributor

I came across these fixtures in OFL today, and they don't really fit the schema. The former declares 10 "modes" to redefine physical attributes for different combinations of bulbs and lenses. I suppose that may be useful in some lighting software, but it's confusing and inconsistent to define it this way. Other fixtures (say, a Source Four LED) can also accept many lens tubes, but we don't multiply out its DMX "modes" for every possible lens (nor should we).

If we want to keep these fixtures in OFL, I think it would be nice to have (in order of simplest to most complex):

  1. a new category called "Conventional"
  2. allow/require Conventionals to have no DMX channels (the single-channel model is inaccurate, anyway: you could use it with a 16-bit dimmer)
  3. turn "physical" into a list, or at least allow lists for "lens" and "bulb" (e.g., the Source Four family could use this, instead of simply declaring that its lens angle is "5…90°", which is very different from zoom lenses in other fixtures which use the same field)

@FloEdelmann
Copy link
Member Author

Hmm I guess you have a point there. It's probably best to remove the existing non-DMX fixtures from OFL then.

the single-channel model is inaccurate, anyway: you could use it with a 16-bit dimmer

Never thought of that, but true!

allow lists for "lens" and "bulb" (e.g., the Source Four family could use this, instead of simply declaring that its lens angle is "5…90°", which is very different from zoom lenses in other fixtures which use the same field)

Sounds like a good improvement nevertheless. Note that Zoom capabilities can already define specific lens angles, so the distinction is currently already in the data (but subtle).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-fixture Affects one or more existing fixture definitions. component-schema Affects the fixture JSON schema.
Projects
None yet
Development

No branches or pull requests

3 participants