Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture evolite/moving-beam-12x10 #1473

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Update manufacturers.json
  • Add fixture 'evolite/moving-beam-12x10'

Fixture warnings / errors

  • evolite/moving-beam-12x10
    • ❌ File does not match schema: fixture.matrix.pixelCount[0] -Infinity should be >= 1
    • ⚠️ Please check if manufacturer is correct and add manufacturer URL.
    • ⚠️ Please add 13 canaux mode's Head initial structure #1 to the fixture's matrix. The included channels were Pan, Tilt.

Thank you jordan!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Sep 23, 2020
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-1473 September 23, 2020 19:51 Inactive
@FloEdelmann
Copy link
Member Author

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ evolite / moving-beam-12x10: d-light / attributes-correctness
  • ✔️ evolite/moving-beam-12x10-13 canaux.xml
evolite / moving-beam-12x10: millumin / json-schema-conformity
  • ❌ evolite/moving-beam-12x10.jsonTypeError: Cannot use 'in' operator to search for 'type' in null
evolite / moving-beam-12x10: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/evolite-moving-beam-12x10.qxfNamespace(convert=None, map=False, validate=['.']) manufacturer/fixture.qxf: Invalid PAN degrees manufacturer/fixture.qxf: Invalid TILT degrees 1 definitions processed. 2 errors detected
evolite / moving-beam-12x10: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/evolite-moving-beam-12x10.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Layout', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

@FloEdelmann FloEdelmann marked this pull request as draft February 16, 2023 16:57
@FloEdelmann FloEdelmann changed the title Add fixture 'evolite/moving-beam-12x10' Add fixture evolite/moving-beam-12x10 Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant