Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify JSON Schemas #1998

Merged
merged 12 commits into from Jun 20, 2021
Merged

Simplify JSON Schemas #1998

merged 12 commits into from Jun 20, 2021

Conversation

FloEdelmann
Copy link
Member

  • Define $schema property in regular properties rather than in patternProperties
  • Simplify plugin schema with default instead of an enum + allowed free text
  • Simplify wheel-slot and capability schemas with discriminator and oneOf
  • Fix required and additional properties
  • Define type and pattern in the same object
  • Simplify oneOf
  • Replace some $comments with descriptions → will be shown in VS Code

@FloEdelmann FloEdelmann added component-schema Affects the fixture JSON schema. refactoring Improves code quality. labels Jun 20, 2021
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-1998 June 20, 2021 12:58 Inactive
@github-actions

This comment has been minimized.

Sign in to view
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-1998 June 20, 2021 13:18 Inactive
@github-actions

This comment has been minimized.

Sign in to view
@FloEdelmann FloEdelmann merged commit 587507d into master Jun 20, 2021
@FloEdelmann FloEdelmann deleted the simplify-schemas branch June 20, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component-schema Affects the fixture JSON schema. refactoring Improves code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FloEdelmann