Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture 'Varytec Giga Bar Frost Pix 8 RGB' #2851

Merged
merged 6 commits into from
Oct 13, 2022
Merged

Add fixture 'Varytec Giga Bar Frost Pix 8 RGB' #2851

merged 6 commits into from
Oct 13, 2022

Conversation

luc122c
Copy link
Contributor

@luc122c luc122c commented Oct 13, 2022

Hi @FloEdelmann! This PR supersedes the automatic one (#2842) as I have added the links that I was not able to add when importing the QLC+ file. As per your issue #2429, I've completed the following checks:

Checking whether at least 3 links are present. Otherwise, finding suitable links.

  • link to a manual PDF containing all DMX modes

  • link to a product page on the official manufacturer website

  • link to a YouTube or Vimeo video that showcases or explains the fixture

  • Checking whether all DMX modes from the manual are included in the fixture definition.

  • Checking whether all DMX modes' channels from the manual are included in the fixture definition.

  • Checking whether all DMX channels' capabilities from the manual are included in the fixture definition.

For the fixtures passing these tests, these are some common tasks that often need to be fixed:

  • replace capability type StrobeSpeed with ShutterStrobe where that one fits better
  • replace capability type Generic with Maintenance where that one fits better
  • rename modes that have no name in the manual to the usual 5-channel/5ch format
  • link to an English manual / product page (if one exists) instead of one in another language
  • Pull requests with these fixes against the original fixture pull requests

I'd much appreciate if you could close the automatic PR and merge this one. I have also emailed you about helping to clear the backlog of new fixtures.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixture definition! I already improved it a bit, but I still have some open questions. We can turn them into helpWanted messages though if you don't have access to the fixture.

Comment on lines +157 to +159
"dmxRange": [64, 231],
"type": "Effect",
"effectName": "Built-in automatic show programs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there are multiple programs here? Can you tell at which DMX values the effects change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the 'Operating mode ‘Built-in automatic show’' section of the manual, there are multiple shows (Pr01 - Pr21) and options to set a 'background colour' and a 'hopping colour'. However, these options only seem available when the fixture is not being DMX controlled.
In DMX 2ch mode, the function of Ch2 changes depending on the value of Ch1. This was difficult behaviour to program in QLC+. I had to use the Aliases feature which was new to me. Ch2 only changes the speed, there is no mention of being able to select a program. I'm therefore not sure if it cycles through Pr01 - Pr21 or just sticks to one.
I can test the fixture at the weekend and report back.

@FloEdelmann FloEdelmann added the new-fixture Request or implementation to add a new fixture definition. label Oct 13, 2022
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I added helpWanted messages, so we can merge this now. Please open a new PR with the fixes when/if you can! :)

@FloEdelmann FloEdelmann changed the title Add fixture Varytec Giga Bar Frost Pix 8 RGB Add fixture 'Varytec Giga Bar Frost Pix 8 RGB' Oct 13, 2022
@FloEdelmann FloEdelmann enabled auto-merge (squash) October 13, 2022 22:28
@FloEdelmann FloEdelmann merged commit e5f9ee6 into OpenLightingProject:master Oct 13, 2022
@luc122c luc122c deleted the branch2022-10-12T09-47-45 branch October 13, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants