Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow down RDM ID range in schema #3621

Merged
merged 4 commits into from Nov 17, 2023

Conversation

kengruven
Copy link
Contributor

According to the RDM webpage 1, manufacturer IDs are restricted to 0001-7FFF.

According to the RDM webpage [1], manufacturer IDs are restricted to 0001-7FFF.

[1]: https://www.rdmprotocol.org/rdm/developers/manufacturer-ids/
@FloEdelmann FloEdelmann added the component-schema Affects the fixture JSON schema. label Nov 13, 2023
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks like a good improvement!

Could you please update the version field in all schemas/*.json files from 12.4.0 to 12.4.1? And afterwards, please run npm run build-without-nuxt.

@FloEdelmann FloEdelmann changed the title RDM ID range Narrow down RDM ID range in schema Nov 13, 2023
@kengruven
Copy link
Contributor Author

I'm not familiar with "npm". I tried running npm run build-without-nuxt but it just gave an error. I looked in the OFL developer documentation and the first step was npm install, which seemed to do something to the working copy, so I ran that, and then npm run build-without-nuxt. That time it seemed to work, or at least, it downloaded a few hundred MB and took a while.

In the end, the only change (in a non-ignored file) was exportPluginVersion in plugins/plugins.json changed from 12.4.0 to 12.4.1 -- is that the one bit you want me to change in the repo? :-)

from "npm install && npm build-without-nuxt"
@FloEdelmann
Copy link
Member

I'm not familiar with "npm".

Sorry, I thought you have the local setup up and running.

at least, it downloaded a few hundred MB and took a while

Yeah, that's an accurate first impression of NPM 😅

In the end, the only change (in a non-ignored file) was exportPluginVersion in plugins/plugins.json changed from 12.4.0 to 12.4.1 -- is that the one bit you want me to change in the repo? :-)

I didn't remember that it was only this one place that would be changed, but it seems correct. Thanks for going through the hassle!

@FloEdelmann FloEdelmann enabled auto-merge (squash) November 17, 2023 08:16
@FloEdelmann FloEdelmann merged commit 8d00d5b into OpenLightingProject:master Nov 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-schema Affects the fixture JSON schema.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants