Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RJ45 DMX connector #3831

Merged
merged 2 commits into from Mar 5, 2024
Merged

Add RJ45 DMX connector #3831

merged 2 commits into from Mar 5, 2024

Conversation

FloEdelmann
Copy link
Member

Needed for #3824.

Since #202 is more involved, let's go with the simpler interim solution and just add RJ45.

@FloEdelmann FloEdelmann added the component-schema Affects the fixture JSON schema. label Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

Plugin export diff

(Output of test script tests/github/export-diff.js.)

You can view your uncommitted changes in plugin exports manually by executing:
$ node cli/diff-plugin-outputs.js -p <plugin-key> [-c <compare-plugin-key>] <fixtures>

💤 afx/lmh460z: qlcplus_4.12.2 Outputted files not changed.
💤 astera/fp3-hyperion-tube: qlcplus_4.12.2 Outputted files not changed.
💤 ayrton/diablo-tc: qlcplus_4.12.2 Outputted files not changed.
💤 cameo/auro-beam-150: qlcplus_4.12.2 Outputted files not changed.
💤 cameo/auro-spot-400: qlcplus_4.12.2 Outputted files not changed.
💤 cameo/hydrabeam-300-rgbw: qlcplus_4.12.2 Outputted files not changed.
💤 flash-professional/led-moving-head-150w: qlcplus_4.12.2 Outputted files not changed.
💤 generic/pan-tilt: qlcplus_4.12.2 Outputted files not changed.
💤 glp/impression-laser: qlcplus_4.12.2 Outputted files not changed.
💤 glp/knv-arc: qlcplus_4.12.2 Outputted files not changed.
💤 lixada/mini-moving-head-rgbw: qlcplus_4.12.2 Outputted files not changed.
💤 martin/mac-axiom-hybrid: qlcplus_4.12.2 Outputted files not changed.
💤 martin/mac-encore-performance: qlcplus_4.12.2 Outputted files not changed.
💤 martin/mania-scx500: qlcplus_4.12.2 Outputted files not changed.
💤 mdg/theone-atmospheric-generator: qlcplus_4.12.2 Outputted files not changed.
💤 prolights/diamond19: qlcplus_4.12.2 Outputted files not changed.
💤 qtx/lux-ld01: qlcplus_4.12.2 Outputted files not changed.
💤 robe/robin-viva-cmy: qlcplus_4.12.2 Outputted files not changed.
💤 stairville/mh-x30: qlcplus_4.12.2 Outputted files not changed.
💤 stairville/mh-x60: qlcplus_4.12.2 Outputted files not changed.
💤 varytec/hero-wash-340fx-rgbw-zoom: qlcplus_4.12.2 Outputted files not changed.

Copy link

github-actions bot commented Mar 5, 2024

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ afx / lmh460z: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/AFX-LMH460Z.qxf
✔️ afx / lmh460z: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/AFX-LMH460Z.qxf
✔️ astera / fp3-hyperion-tube: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Astera-FP3-Hyperion-Tube.qxf
✔️ astera / fp3-hyperion-tube: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Astera-FP3-Hyperion-Tube.qxf
✔️ ayrton / diablo-tc: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Ayrton-Diablo-TC.qxf
✔️ ayrton / diablo-tc: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Ayrton-Diablo-TC.qxf
✔️ cameo / auro-beam-150: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/cameo-Auro-Beam-150.qxf
✔️ cameo / auro-beam-150: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/cameo-Auro-Beam-150.qxf
✔️ cameo / auro-spot-400: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/cameo-Auro-Spot-400.qxf
✔️ cameo / auro-spot-400: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/cameo-Auro-Spot-400.qxf
✔️ cameo / hydrabeam-300-rgbw: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/cameo-Hydrabeam-300-RGBW.qxf
✔️ cameo / hydrabeam-300-rgbw: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/cameo-Hydrabeam-300-RGBW.qxf
✔️ flash-professional / led-moving-head-150w: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Flash-Professional-LED-Moving-Head-150W.qxf
✔️ flash-professional / led-moving-head-150w: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Flash-Professional-LED-Moving-Head-150W.qxf
generic / pan-tilt: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Generic-PanTilt-Fader.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected 1 definitions processed. 1 errors detected
generic / pan-tilt: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Generic-PanTilt-Fader.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
✔️ glp / impression-laser: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/GLP-impression-Laser.qxf
✔️ glp / impression-laser: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/GLP-impression-Laser.qxf
✔️ glp / knv-arc: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/GLP-KNV-Arc.qxf
✔️ glp / knv-arc: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/GLP-KNV-Arc.qxf
✔️ lixada / mini-moving-head-rgbw: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Lixada-Mini-Moving-Head-RGBW.qxf
✔️ lixada / mini-moving-head-rgbw: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Lixada-Mini-Moving-Head-RGBW.qxf
✔️ martin / mac-axiom-hybrid: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Martin-MAC-Axiom-Hybrid.qxf
✔️ martin / mac-axiom-hybrid: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Martin-MAC-Axiom-Hybrid.qxf
✔️ martin / mac-encore-performance: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Martin-MAC-Encore-Performance.qxf
✔️ martin / mac-encore-performance: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Martin-MAC-Encore-Performance.qxf
✔️ martin / mania-scx500: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Martin-Mania-SCX500.qxf
✔️ martin / mania-scx500: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Martin-Mania-SCX500.qxf
✔️ mdg / theone-atmospheric-generator: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/MDG-theONE-Atmospheric-Generator.qxf
✔️ mdg / theone-atmospheric-generator: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/MDG-theONE-Atmospheric-Generator.qxf
✔️ prolights / diamond19: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Prolights-DIAMOND19.qxf
✔️ prolights / diamond19: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Prolights-DIAMOND19.qxf
✔️ qtx / lux-ld01: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/QTX-Lux-Ld01.qxf
✔️ qtx / lux-ld01: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/QTX-Lux-Ld01.qxf
✔️ robe / robin-viva-cmy: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Robe-ROBIN-Viva-CMY.qxf
✔️ robe / robin-viva-cmy: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Robe-ROBIN-Viva-CMY.qxf
stairville / mh-x30: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Stairville-MH-x30.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf:Color Wheel/Purple/Res1: FX color Purple (#ff00ff) should have color code #a020f0, the name for given FX color code is Magenta 1 definitions processed. 1 errors detected
✔️ stairville / mh-x30: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Stairville-MH-x30.qxf
stairville / mh-x60: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Stairville-MH-X60.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf:Color Wheel/Pink/Res1: FX color Pink (#ff00ff) should have color code #ffc0cb, the name for given FX color code is Magenta 1 definitions processed. 1 errors detected
  • ✔️ gobos/ofl/10-circles.svg
✔️ stairville / mh-x60: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Stairville-MH-X60.qxf
  • ✔️ gobos/ofl/10-circles.svg
✔️ varytec / hero-wash-340fx-rgbw-zoom: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Varytec-Hero-Wash-340FX-RGBW-Zoom.qxf
✔️ varytec / hero-wash-340fx-rgbw-zoom: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Varytec-Hero-Wash-340FX-RGBW-Zoom.qxf

This comment was marked as resolved.

@FloEdelmann FloEdelmann changed the title Add RJ45 DMX connector Add RJ45 DMX connector Mar 5, 2024
@FloEdelmann FloEdelmann merged commit ba9a428 into master Mar 5, 2024
4 checks passed
@FloEdelmann FloEdelmann deleted the dmx-connector-rj45 branch March 5, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-schema Affects the fixture JSON schema.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant