Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix matrix order for two fixtures #393

Merged
merged 2 commits into from Jan 27, 2018
Merged

Fix matrix order for two fixtures #393

merged 2 commits into from Jan 27, 2018

Conversation

FloEdelmann
Copy link
Member

See these comments in the QLC+ forum:

@FloEdelmann FloEdelmann added the component-fixture Affects one or more existing fixture definitions. label Jan 27, 2018
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-393 January 27, 2018 09:07 Inactive
@FloEdelmann
Copy link
Member Author

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

Fixture american-dj/revo-burst changed in this PR

  • d-light
    • attributes-correctness
      • ✅ american-dj/revo-burst-4ch.xml
      • ✅ american-dj/revo-burst-10ch.xml
  • ecue
  • ofl
  • qlcplus
    • xsd-schema-conformity
      • ✅ American-DJ-Revo-Burst.qxf

Fixture venue/tristrip3z changed in this PR

  • d-light
    • attributes-correctness
      • ✅ venue/tristrip3z-3ch.xml
      • ✅ venue/tristrip3z-6ch.xml
      • ✅ venue/tristrip3z-8ch.xml
      • ✅ venue/tristrip3z-9ch.xml
      • ✅ venue/tristrip3z-14ch.xml
  • ecue
  • ofl
  • qlcplus
    • xsd-schema-conformity
      • ✅ Venue-TriStrip3Z.qxf

@FloEdelmann
Copy link
Member Author

Broken links

(Output of test script tests/http-status.js.)

There were 0 internal and 1 external links failing.

@FloEdelmann
Copy link
Member Author

Plugin export diff

(Output of test script tests/github/export-diff.js.)

You can run view your uncommited changes in plugin exports manually by executing:
$ node cli/diff-plugin-outputs.js -p <plugin name> <fixtures>

Fixture american-dj/revo-burst modified in this PR

Fixture output to all plugins is checked.

ℹ️ Plugin d-light

Outputted files not changed.

⚠️ Plugin ecue

Changed outputted file UserLibrary.xml 
--- removed
+++ added
@@ -2,9 +2,9 @@
 <Document Owner="user" TypeVersion="2" SaveTimeStamp="2018-01-27#09:23:31">
     <Library>
         <Fixtures>
             <Manufacturer _CreationDate="2018-01-27#09:23:31" _ModifiedDate="2018-01-27#09:23:31" Name="American DJ" Comment="" Web="http://www.adj.com/">
-                <Fixture _CreationDate="2018-01-24#00:00:00" _ModifiedDate="2018-01-24#00:00:00" Name="Revo Burst (4ch mode)" NameShort="ADJRevoBurst-4ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/american-dj/revo-burst" AllocateDmxChannels="4" Weight="3.2" Power="20" DimWidth="216" DimHeight="239" DimDepth="312">
+                <Fixture _CreationDate="2018-01-24#00:00:00" _ModifiedDate="2018-01-27#00:00:00" Name="Revo Burst (4ch mode)" NameShort="ADJRevoBurst-4ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/american-dj/revo-burst" AllocateDmxChannels="4" Weight="3.2" Power="20" DimWidth="216" DimHeight="239" DimDepth="312">
                     <ChannelBeam Name="Mode" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="1" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="1">
                         <Range Name="Pattern" Start="0" End="119" AutoMenu="1" Centre="0"/>
                         <Range Name="Chase" Start="120" End="239" AutoMenu="1" Centre="0"/>
                         <Range Name="Sound active" Start="240" End="255" AutoMenu="1" Centre="0"/>
@@ -32,9 +32,9 @@
                         <Range Name="Strobe slow - fast" Start="10" End="255" AutoMenu="1" Centre="0"/>
                     </ChannelBeam>
                     <ChannelIntensity Name="Dimmer" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="4" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="4"/>
                 </Fixture>
-                <Fixture _CreationDate="2018-01-24#00:00:00" _ModifiedDate="2018-01-24#00:00:00" Name="Revo Burst (10ch mode)" NameShort="ADJRevoBurst-10ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/american-dj/revo-burst" AllocateDmxChannels="10" Weight="3.2" Power="20" DimWidth="216" DimHeight="239" DimDepth="312">
+                <Fixture _CreationDate="2018-01-24#00:00:00" _ModifiedDate="2018-01-27#00:00:00" Name="Revo Burst (10ch mode)" NameShort="ADJRevoBurst-10ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/american-dj/revo-burst" AllocateDmxChannels="10" Weight="3.2" Power="20" DimWidth="216" DimHeight="239" DimDepth="312">
                     <ChannelBeam Name="Mode" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="1" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="1">
                         <Range Name="Pattern" Start="0" End="119" AutoMenu="1" Centre="0"/>
                         <Range Name="Chase" Start="120" End="239" AutoMenu="1" Centre="0"/>
                         <Range Name="Sound active" Start="240" End="255" AutoMenu="1" Centre="0"/>

ℹ️ Plugin qlcplus

Outputted files not changed.

Fixture venue/tristrip3z modified in this PR

Fixture output to all plugins is checked.

ℹ️ Plugin d-light

Outputted files not changed.

⚠️ Plugin ecue

Changed outputted file UserLibrary.xml 
--- removed
+++ added
@@ -2,14 +2,14 @@
 <Document Owner="user" TypeVersion="2" SaveTimeStamp="2018-01-27#09:23:31">
     <Library>
         <Fixtures>
             <Manufacturer _CreationDate="2018-01-27#09:23:31" _ModifiedDate="2018-01-27#09:23:31" Name="Venue" Comment="Venue by Proline" Web="http://venuelightingeffects.com/">
-                <Fixture _CreationDate="2018-01-25#00:00:00" _ModifiedDate="2018-01-25#00:00:00" Name="TriStrip3Z (3ch mode)" NameShort="VenueTriStrip3Z-3ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/venue/tristrip3z" AllocateDmxChannels="3" Weight="2.8" Power="27" DimWidth="1042" DimHeight="60" DimDepth="138">
+                <Fixture _CreationDate="2018-01-25#00:00:00" _ModifiedDate="2018-01-27#00:00:00" Name="TriStrip3Z (3ch mode)" NameShort="VenueTriStrip3Z-3ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/venue/tristrip3z" AllocateDmxChannels="3" Weight="2.8" Power="27" DimWidth="1042" DimHeight="60" DimDepth="138">
                     <ChannelColor Name="Red All Zones" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="1" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="1"/>
                     <ChannelColor Name="Green All Zones" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="2" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="2"/>
                     <ChannelColor Name="Blue All Zones" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="3" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="3"/>
                 </Fixture>
-                <Fixture _CreationDate="2018-01-25#00:00:00" _ModifiedDate="2018-01-25#00:00:00" Name="TriStrip3Z (6ch mode)" NameShort="VenueTriStrip3Z-6ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/venue/tristrip3z" AllocateDmxChannels="6" Weight="2.8" Power="27" DimWidth="1042" DimHeight="60" DimDepth="138">
+                <Fixture _CreationDate="2018-01-25#00:00:00" _ModifiedDate="2018-01-27#00:00:00" Name="TriStrip3Z (6ch mode)" NameShort="VenueTriStrip3Z-6ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/venue/tristrip3z" AllocateDmxChannels="6" Weight="2.8" Power="27" DimWidth="1042" DimHeight="60" DimDepth="138">
                     <ChannelColor Name="Red All Zones" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="1" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="1"/>
                     <ChannelColor Name="Green All Zones" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="2" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="2"/>
                     <ChannelColor Name="Blue All Zones" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="3" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="3"/>
                     <ChannelIntensity Name="Dimmer" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="4" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="4"/>
@@ -24,9 +24,9 @@
                         <Range Name="Dimmer speed mode 2 (medium speed)" Start="153" End="203" AutoMenu="1" Centre="0"/>
                         <Range Name="Dimmer speed mode 3 (slow speed)" Start="204" End="255" AutoMenu="1" Centre="0"/>
                     </ChannelBeam>
                 </Fixture>
-                <Fixture _CreationDate="2018-01-25#00:00:00" _ModifiedDate="2018-01-25#00:00:00" Name="TriStrip3Z (8ch mode)" NameShort="VenueTriStrip3Z-8ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/venue/tristrip3z" AllocateDmxChannels="8" Weight="2.8" Power="27" DimWidth="1042" DimHeight="60" DimDepth="138">
+                <Fixture _CreationDate="2018-01-25#00:00:00" _ModifiedDate="2018-01-27#00:00:00" Name="TriStrip3Z (8ch mode)" NameShort="VenueTriStrip3Z-8ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/venue/tristrip3z" AllocateDmxChannels="8" Weight="2.8" Power="27" DimWidth="1042" DimHeight="60" DimDepth="138">
                     <ChannelColor Name="Red All Zones" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="1" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="1"/>
                     <ChannelColor Name="Green All Zones" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="2" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="2"/>
                     <ChannelColor Name="Blue All Zones" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="3" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="3"/>
                     <ChannelColor Name="Color Macros" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="4" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="4">
@@ -66,9 +66,9 @@
                         <Range Name="Dimmer speed mode 2 (medium speed)" Start="153" End="203" AutoMenu="1" Centre="0"/>
                         <Range Name="Dimmer speed mode 3 (slow speed)" Start="204" End="255" AutoMenu="1" Centre="0"/>
                     </ChannelBeam>
                 </Fixture>
-                <Fixture _CreationDate="2018-01-25#00:00:00" _ModifiedDate="2018-01-25#00:00:00" Name="TriStrip3Z (9ch mode)" NameShort="VenueTriStrip3Z-9ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/venue/tristrip3z" AllocateDmxChannels="9" Weight="2.8" Power="27" DimWidth="1042" DimHeight="60" DimDepth="138">
+                <Fixture _CreationDate="2018-01-25#00:00:00" _ModifiedDate="2018-01-27#00:00:00" Name="TriStrip3Z (9ch mode)" NameShort="VenueTriStrip3Z-9ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/venue/tristrip3z" AllocateDmxChannels="9" Weight="2.8" Power="27" DimWidth="1042" DimHeight="60" DimDepth="138">
                     <ChannelColor Name="Red Zone 1" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="1" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="1"/>
                     <ChannelColor Name="Green Zone 1" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="2" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="2"/>
                     <ChannelColor Name="Blue Zone 1" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="3" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="3"/>
                     <ChannelColor Name="Red Zone 2" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="4" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="4"/>
@@ -77,9 +77,9 @@
                     <ChannelColor Name="Red Zone 3" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="7" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="7"/>
                     <ChannelColor Name="Green Zone 3" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="8" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="8"/>
                     <ChannelColor Name="Blue Zone 3" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="9" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="9"/>
                 </Fixture>
-                <Fixture _CreationDate="2018-01-25#00:00:00" _ModifiedDate="2018-01-25#00:00:00" Name="TriStrip3Z (14ch mode)" NameShort="VenueTriStrip3Z-14ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/venue/tristrip3z" AllocateDmxChannels="14" Weight="2.8" Power="27" DimWidth="1042" DimHeight="60" DimDepth="138">
+                <Fixture _CreationDate="2018-01-25#00:00:00" _ModifiedDate="2018-01-27#00:00:00" Name="TriStrip3Z (14ch mode)" NameShort="VenueTriStrip3Z-14ch" Comment="generated by the Open Fixture Library – https://open-fixture-library.herokuapp.com/venue/tristrip3z" AllocateDmxChannels="14" Weight="2.8" Power="27" DimWidth="1042" DimHeight="60" DimDepth="138">
                     <ChannelColor Name="Red Zone 1" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="1" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="1"/>
                     <ChannelColor Name="Green Zone 1" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="2" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="2"/>
                     <ChannelColor Name="Blue Zone 1" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="3" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="3"/>
                     <ChannelColor Name="Red Zone 2" DefaultValue="0" Highlight="255" Deflection="0" DmxByte0="4" DmxByte1="0" Constant="0" Crossfade="0" Invert="0" Precedence="LTP" ClassicPos="4"/>

ℹ️ Plugin qlcplus

Outputted files not changed.

@FloEdelmann FloEdelmann merged commit 5851fb8 into master Jan 27, 2018
@FloEdelmann FloEdelmann deleted the matrix-order branch January 27, 2018 15:55
@snyk-bot snyk-bot mentioned this pull request Mar 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxedel fxedel fxedel approved these changes

Assignees
No one assigned
Labels
component-fixture Affects one or more existing fixture definitions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FloEdelmann @fxedel