-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capability types #425
Merged
Merged
Capability types #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@FloEdelmann Please already review the schema, the capability type documentation and the 12 fixtures that have already been adapted to the new syntax. Hopefully, we can finalize the syntax then so we can update the remaining 99 fixtures without worrying about bigger schema changes in the further lifetime of this PR. |
FloEdelmann
requested changes
Mar 7, 2018
…e-library into new-capabilities
This comment has been minimized.
This comment has been minimized.
FloEdelmann
approved these changes
Jul 21, 2018
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component-editor
Affects the fixture editor.
component-fixture
Affects one or more existing fixture definitions.
component-model
Affects the fixture model ES classes.
component-plugin
Affects one or more import or export plugins.
component-schema
Affects the fixture JSON schema.
component-test
Affects the automated tests.
component-ui
Affects the user interface on the open-fixture-library.org website.
difficulty-medium
Some research is needed before implementation, or implementation is time-consuming.
documentation
Improves the Markdown docs, or in-code JSDoc comments, or user documentation on the website.
priority-medium
Great to have in the long run, but not urgent.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #267. #177 and #437 will be added in a future pull request, but we make the syntax ready to make it easy later.
Some links:
Todo
Add Hue, Saturation capability types(work for Better handle HSV/HSB/HSI/HSL channels #505)Color names <-> Hex codes(work for Alternatives for color hex strings #437)channel.type
channel.color
channel.invert
channel.crossfade
capability.name
Do this in another PRcapability.menuClick
?Do this in another PRcapability.helpWanted
for ColorPreset capabilities without acolors
propertyshutterEffect
is neither Closed nor OpeneffectName
would also be a valideffectPreset
index
has different start / end values:colors
must not be stepped!colors
property for ColorWheelIndex capabilitieshelpWanted
properties in the fixtureslastModifyDate
in all fixtures