Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Airflow: Remove explicit pass from several extract_on_complete methods. #1771

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Airflow: Remove explicit pass from several extract_on_complete methods. #1771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions integration/airflow/openlineage/airflow/extractors/gcs_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,3 @@ def extract(self) -> Optional[TaskMetadata]:
inputs=input_objects,
outputs=[output_object],
)

def extract_on_complete(self, task_instance) -> Optional[TaskMetadata]:
pass
3 changes: 0 additions & 3 deletions integration/airflow/openlineage/airflow/extractors/great_expectations_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ def get_operator_classnames(cls) -> List[str]:
def extract(self) -> Optional[TaskMetadata]:
return None

def extract_on_complete(self, task_instance) -> Optional[TaskMetadata]:
return None


if _has_great_expectations:
GreatExpectationsExtractor = GreatExpectationsExtractorImpl
Expand Down
3 changes: 0 additions & 3 deletions integration/airflow/openlineage/airflow/extractors/s3_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@ def extract(self) -> Optional[TaskMetadata]:
outputs=[output_object],
)

def extract_on_complete(self, task_instance) -> Optional[TaskMetadata]:
pass


class S3FileTransformExtractor(BaseExtractor):
@classmethod
Expand Down
14 changes: 12 additions & 2 deletions integration/airflow/tests/integration/requests/gcs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,22 @@
}
},{
"eventType" : "COMPLETE",
"inputs" : [],
"inputs" : [
{
"name" : "{{ env_var('GOOGLE_CLOUD_STORAGE_SOURCE_URI') }}",
"namespace" : "{{ env_var('GOOGLE_CLOUD_STORAGE_SOURCE_URI') | url_scheme_authority }}"
}
],
"job" : {
"facets": {},
"name" : "gcs_dag.gcs_task"
},
"outputs" : [],
"outputs" : [
{
"name" : "{{ env_var('GOOGLE_CLOUD_STORAGE_DESTINATION_URI') }}",
"namespace" : "{{ env_var('GOOGLE_CLOUD_STORAGE_DESTINATION_URI') | url_scheme_authority }}"
}
],
"run" : {
"facets" : {}
}
Expand Down
14 changes: 12 additions & 2 deletions integration/airflow/tests/integration/requests/s3copy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,22 @@
}
},{
"eventType": "COMPLETE",
"inputs": [],
"inputs": [
{
"name": "testfile",
"namespace": "s3://testbucket"
}
],
"job": {
"facets": {},
"name": "s3copy_dag.s3copy_task"
},
"outputs": [],
"outputs": [
{
"name": "testfile2",
"namespace": "s3://testbucket"
}
],
"run": {
"facets": {}
}
Expand Down