New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search/filter functionality to object selection window #1837
Merged
AaronVanGeffen
merged 19 commits into
OpenLoco:master
from
AaronVanGeffen:objsel/filter
Feb 16, 2023
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1f9bae7
TextInput: fix handleInput when no input length limit is set
AaronVanGeffen 7b4b17e
ObjectSelectionWindow: add full text input functionality
AaronVanGeffen 2f12968
ObjectSelectionWindow: rename _tabInformation to _tabPositions
AaronVanGeffen fdac3e7
ObjectSelectionWindow: rename _50D144 to _objectSelection
AaronVanGeffen b7a8990
ObjectSelectionWindow: rename _52334{A,C} to _mousePos{X,Y}
AaronVanGeffen 2aa7bd8
ObjectSelectionWindow: rename sub_472BBC to getFirstAvailableSelected…
AaronVanGeffen 3d770e8
ObjectSelectionWindow: cache vector with object list for current tab
AaronVanGeffen 08190bf
ObjectSelectionWindow: implement case-insensitive filtering
AaronVanGeffen 33e647a
ObjectSelectionWindow: keep visibility into account in getObjectFromS…
AaronVanGeffen cbb177d
ObjectSelectionWindow: only count visible objects for getScrollSize
AaronVanGeffen e148476
Amend changelog
AaronVanGeffen 150239c
Keyboard: allow using screenshot shortcut in object selection window,…
AaronVanGeffen 73d3494
drawSearchBox: reuse rather than shadow a local
AaronVanGeffen 6a151b9
Add 'Clear' button next to text input
AaronVanGeffen f353bce
Construct pattern directly from buffer, no need to go through c_str
AaronVanGeffen e597e4e
Apply suggestions from code review
AaronVanGeffen a3d4118
Reserve space in vector before iterating over objects
AaronVanGeffen 620c306
populateTabObjectList: apply std::move to entry
AaronVanGeffen f76660f
Use enum class to denote visibility
AaronVanGeffen File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should start handling these through the window manager, ideally passing through to an event for the active window only. Something for a future PR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah i was a bit confused as to what this was about.