abs2prom not recorded to driver_metadata table since it is already recorded to metadata table

[hschilling]

Summary

abs2prom not recorded to driver_metadata table since it is already recorded to metadata table

Related Issues

• Resolves abs2prom is recorded twice in the case recorder file #1276

Backwards incompatibilities

None

New Dependencies

None

[swryan]

It seems like the n2 viewer does not need abs2prom at all since removing it from viewer_data does not break test_viewmodeldata.py:TestViewModelData.test_n2_from_sqlite. Is that right?

If so then it seems like we should just not add it to data_dict in _get_viewer_data at all rather than pop it later...

[swryan]

from a quick look at n2.html, it looks like abs2prom is optional:

        this.abs2prom = modelJSON.abs2prom; // May be undefined.

            .on("mouseover", function(d) {
                if (self.model.abs2prom != undefined) {
                    if (d.isParam()) {
                        return self.dom.toolTip.text(
                                self.model.abs2prom.input[d.absPathName])
                            .style("visibility", "visible");
                    }
                    if (d.isUnknown()) {
                        return self.dom.toolTip.text(
                                self.model.abs2prom.output[d.absPathName])
                            .style("visibility", "visible");
                    }
                }
            })

so I am wondering what the effect is of not having abs2prom in the dict when viewing the n2 from a recording...