Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auto-ivc component visible again in N2 #1698

Merged
merged 7 commits into from Sep 30, 2020
Merged

Conversation

tadkollar
Copy link
Member

@tadkollar tadkollar commented Sep 25, 2020

Summary

The auto-ivc component is back in the N2 diagram, with the following changes:

  • The component is labeled "Auto-IVC"
  • It is always pre-collapsed
  • Inputs connected to it are colored dark orange

A few small fixes/changes are included:

  • Text labels on collapsed elements are now white instead of black, to make them easier to read against the dark-gray background
  • The [Infinity] value generated by numpy was causing JSON errors, so that's now detected and converted to a string in n2_viewer.py
  • The drag handle on the legend had the dot texture overflowing the shape, which is now fixed

n2_screenshot

Related Issues

Backwards incompatibilities

None

New Dependencies

None

@project-bot project-bot bot added this to In progress in OpenMDAO Dev [Read only] Sep 25, 2020
@tadkollar tadkollar added this to In progress in N2 Issues via automation Sep 25, 2020
@tadkollar tadkollar added the visualization Pertaining to visualization of OpenMDAO data. label Sep 25, 2020
@tadkollar tadkollar changed the title Make auto-ivc component visible again Make auto-ivc component visible again in N2 Sep 25, 2020
@project-bot project-bot bot moved this from In progress to Under review in OpenMDAO Dev [Read only] Sep 25, 2020
@robfalck robfalck self-requested a review September 28, 2020 18:50
OpenMDAO Dev [Read only] automation moved this from Under review to Reviewer approved Sep 28, 2020
@swryan swryan merged commit da4783b into OpenMDAO:master Sep 30, 2020
OpenMDAO Dev [Read only] automation moved this from Reviewer approved to Done Sep 30, 2020
N2 Issues automation moved this from In progress to Done Sep 30, 2020
@tadkollar tadkollar deleted the aivc1684 branch October 5, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visualization Pertaining to visualization of OpenMDAO data.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

N2 should show auto_ivc
4 participants