Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shape_by_conn is broken for parallel to serial connections #56

Closed
anilyil opened this issue Mar 22, 2021 · 2 comments
Closed

shape_by_conn is broken for parallel to serial connections #56

anilyil opened this issue Mar 22, 2021 · 2 comments
Assignees

Comments

@anilyil
Copy link
Collaborator

anilyil commented Mar 22, 2021

I merged the PR that removed all of the src_indices from the wrappers and replaced it with shape by conn (#51). However, I did not realize a certain type of connections would be broken this way. I will now work towards resolving this issue in the short term, but users should keep this in mind. Currently, the master branch is broken for parallel models where a distributed component's output is connected to an input of a serial component where the input is shaped by connection. One example of this type of connection is in the adflow wrapper. The volume mesh and state connection to the adflow functionals group is broken for example.

To avoid this issue, checkout the latest tagged version. I will post updates here once I fix it in the short term, and another update when the shape by connection is fixed on the openmdao side.

@anilyil
Copy link
Collaborator Author

anilyil commented Mar 24, 2021

So master works now because I merged #57. The issue was only with adflow. We will need to keep this in mind after the shape_by_conn behavior is updated, so I will keep this issue open.

@kejacobson
Copy link
Collaborator

shape_by_conn and distributed variables in OpenMDAO changed by POEM 46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants