No murder bounty when a player follower commits murder (Bug #2852) #921

NeveHanter · 2016-04-01T23:53:10Z

This commit fixes https://bugs.openmw.org/issues/2852. I've tested that change and now it properly raises bounty when summon (Skeleton) or the follower (High-Pockets) kills an NPC.

ghost · 2016-04-02T00:06:07Z

apps/openmw/mwmechanics/mechanicsmanagerimp.cpp

        // Doesn't handle possible edge case where no one reported the assault, but in such a case,
        // for bystanders it is not possible to tell who attacked first, anyway.
        if (victimStats.getCrimeId() != -1)
-            commitCrime(attacker, victim, MWBase::MechanicsManager::OT_Murder);
+            commitCrime(attackerIsPlayerFollowerOrSummon ? player : attacker, victim, MWBase::MechanicsManager::OT_Murder);


This doesn't seem to be in line with the original game. Try this:

npc1->aifollow, player, 0,0,0,0 npc1->startcombat, npc2

No bounty is added.

Yes, You're right, my bad, only summons increases bounty (maybe this should be fixed by some compatibility flag, isn't it a some vanilla bug?).

I'm not talking about a difference between summons/normal followers, but the fact that any follower attacking first doesn't produce a bounty for the player.

I suppose that this is a) intended to work this way (kinda makes sense that the player isn't responsible for the follower's actions, if they acted on their own accord) or b) no one really considered this case since followers usually don't attack a peaceful NPC on their own, except maybe for scripted events.

I've tested startcombat, npc_id on the summoned skeleton and high pockets reference and after it killed the NPC it got me 1000 bounty with vanilla. Also I've checked if after I attacked an NPC, and then summon or high pockets killed it, i also got 1000 bounty. The same after I've summoned summon after attacking the NPC, it also got me 1000 bounty.

ghost · 2016-04-04T10:11:16Z

Just checked again, you are right there is a difference in the handling of summons and normal followers. Weird.

But, the current state of this PR no longer fixes the original bug report.

The expected behaviour with aifollow-ing actors is:

Player attacks first, follower kills: murder bounty should be added (this is what the bug report was about).
Follower attacks first and kills without the player getting involved: no murder bounty should be added.

NeveHanter · 2016-12-11T12:26:26Z

Hello again @scrawl,

I want to complete this PR at last.

I've checked vanilla behaviour again with following actors:

summon,
aifollow'ed NPC,
aiescort'ed NPC,
recruited High-Pockets

in the following scenarios:

by issuing startcombat command on different NPC in crowded room,
by me attacking NPC

In every of the eight scenarios, I've got 1000 bounty for "siding with me" actor killing other NPC, but in startcombat scenario no-one of the other NPCs in the room attacked me afterwards getting the bounty (of course guards wanted to throw me in jail anyway)

And this conflicts with your last comment:

Follower attacks first and kills without the player getting involved: no murder bounty should be added.

Additionally I've checked what happens if aifollow'ing/aiescort'ing actor summon kills an NPC, and when I've attacked that NPC and "follower" summon killed him, I've got the bounty, but when I've used startcombat on my follower and his summon killed the NPC, I've got no bounty at all.
This looks like a vanilla bug for me, because when following NPC kills another NPC, I got the bounty, but when his summon kills an NPC, I didn't get it.

ghost · 2016-12-13T14:11:23Z

Looks like you're right. I don't remember what testing I did before, maybe I was impatient and used 'sethealth 0' after the initial attack to speed things up, but in doing so made the game not attribute the death to the attacking actor.

Feel free to go ahead with implementation.

…ills NPC (Bug #2852) Made damage spell effects casted by actors different than the player, also notify about target death (allows spellcasting summons/siding actors commit crime). Made player summoned creatures, actors siding with the player (AiEscort & AiFollow) and their summoned creatures commit crime in name of the player. Prevent follower summoned creature attack the player when player or his follower/summoned creature commited the crime.

…lower & follower itself

NeveHanter · 2016-12-16T23:08:40Z

@scrawl I've probably made every needed corrections and prepared code for the review.

ghost · 2016-12-17T10:26:22Z

The hasSummonedCreature checks seem redundant, the summoned creature would also have a follow package.

NeveHanter · 2016-12-17T11:19:55Z

Right, my bad as I've had problem in my implementation before and thought it was because summoned creature package wasn't there, everything seems ok after removal 👍

ghost · 2016-12-17T18:40:05Z

apps/openmw/mwmechanics/actors.cpp

@@ -374,9 +374,13 @@ namespace MWMechanics
            if (LOS)
            {
                MWBase::Environment::get().getMechanicsManager()->startCombat(actor1, actor2);
-                if (!againstPlayer) // start combat between each other
+                if (!againstPlayer) // start combat between each other if engaging actor is not one of the player followers


Can you explain why this change is necessary?

This is done to prevent not-committing the crime when startcombat is issued i.e. when I issue "startcombat elone" on arrille, he summons the skeleton and elone starts fighting it without skeleton commiting the crime

More specifically this is done because actorAttacked() checks for !seq.isInCombat(attacker) before calling commitCrime().

Which will of course fail when startcombat is issued in here also for actor2.

start combat between each other if engaging actor is not one of the player followers

That's not how vanilla works, AFAIK. Can you think of a different solution to the problem?

Please check for any conflicts/overlaps with the just merged PR #1174.

ghost · 2016-12-17T18:40:22Z

apps/openmw/mwmechanics/creaturestats.hpp

@@ -12,6 +12,8 @@
 #include "aisequence.hpp"
 #include "drawstate.hpp"

+#include "../mwworld/class.hpp"


Forgot to remove include?

Allofich · 2016-12-19T16:44:27Z

apps/openmw/mwmechanics/mechanicsmanagerimp.cpp

@@ -1094,6 +1082,7 @@ namespace MWMechanics
        }

        // Make surrounding actors within alarm distance respond to the crime
+        // TODO: Vanilla doesn't make neighbors attack player if one of his follower/summon attacks first (probably vanilla bug)


This seems to be because in vanilla followers only give you a crime for a kill, not for attacking. The same thing will happen if you kill an NPC instantly. You will only get the murder bounty and nearby NPCs won't attack you. I guess the code to have them respond is tied to the "on attacked" crime code.

So now, there's question, should we follow vanilla or not regarding this?

I don't think it matters that much, because normally your follower won't start combat with a non-aggressive actor anyway. They just respond to ones that are aggressive to you or them. So this would only matter if there is a script using "startcombat" on the follower, or if the player is using console commands. I suppose the best thing would be to follow vanilla, just in case there is a mod that uses startcombat to make the player follower attack and expects the vanilla behavior, but it seems like a very rare case to me.

Yeah that sounds like the right vanilla behavior. When getting boots of blinding speed, the woman I was helping would just zip off to kill enemies which was annoying to say the least...

jefhai · 2016-12-22T05:59:09Z

@NeveHanter are you working on this issue? https://bugs.openmw.org/issues/2852

If so please mark yourself as the assignee. We wouldn't want others doubling up on this task.

Edit: Resolved.

NeveHanter · 2016-12-23T20:53:48Z

@scrawl Any more comments on this PR or above comment thread about engageCombat changes?

Allofich · 2016-12-24T04:20:57Z

I think maybe he's waiting to merge things until the new release is out. Is that right, scrawl? Or he's just busy with other things.

Allofich · 2016-12-24T11:34:07Z

By the way, I just noticed that in vanilla, the player is given crime bounties for murders that happen during fighting even from the opponents hitting each other with area-effect spells. You can test with Arrille because he will use some spells that can hit other NPCs. The player even gets a murder bounty if you select a non-aggressive NPC A, give it "startcombat" on NPC B who is fighting the player due to a crime, and NPC B is killed. I guess NPCs responding to a crime are labeled to be possible murder victims, and the player gets a murder bounty no matter how such labeled NPCs die. Right now I don't know if we should follow that implementation.

Allofich · 2016-12-27T07:59:25Z

I guess NPCs responding to a crime are labeled to be possible murder victims, and the player gets a murder bounty no matter how such labeled NPCs die.

Any opinions? I suppose I support doing it the same as vanilla, which I think is a good policy for laying a base that could potentially have alternate implementations added on top of it but will get us closer to 1.0. In this case, you could imagine that the law of Morrowind blames the initiator of an assault for all deaths that result from it, even if they didn't directly do it.

ghost · 2017-01-01T20:06:05Z

Any opinions? I suppose I support doing it the same as vanilla, which I think is a good policy for laying a base that could potentially have alternate implementations added on top of it but will get us closer to 1.0. In this case, you could imagine that the law of Morrowind blames the initiator of an assault for all deaths that result from it, even if they didn't directly do it.

Makes sense to me. In some cases (i.e. multiple damage effects in the same frame) you couldn't really tell who made the kill anyway.

akortunov · 2017-07-21T19:19:54Z

apps/openmw/mwmechanics/actors.cpp

@@ -420,6 +420,15 @@ namespace MWMechanics

            if (LOS)


You should add "{" after this line or remove "}" from 431 line to compile OpenMW properly.

ghost · 2017-07-30T23:59:30Z

Current blocker is #921 (review) , I think.

Capostrophic · 2018-06-09T09:36:06Z

This needs some massive cleanup, the actual changes here that are necessary to resolve the issue are somewhat small.

akortunov · 2018-06-19T09:44:41Z

This PR can be closed now.

psi29a · 2018-06-19T11:37:51Z

Closing on advice from @akortunov

ghost reviewed Apr 2, 2016
View reviewed changes

madcow mentioned this pull request Dec 16, 2016

Add bounty when player follower commits murder (#2852) #1163

Closed

Prevent instant engage combat between actor engaged by the player fol…

699de56

…lower & follower itself

Removed redundant hasSummonedCreature checks

2858135

ghost reviewed Dec 17, 2016

View reviewed changes

Removed unnecessary include

2df5b85

Allofich reviewed Dec 19, 2016

View reviewed changes

Allofich mentioned this pull request Dec 23, 2016

Adjustments to AI combat engaging and disengaging #1174

Merged

NeveHanter added 2 commits December 28, 2016 03:29

Merge remote-tracking branch 'upstream/master'

64813bb

Added CLion's default build directory to .gitignore

40a6140

Merge remote-tracking branch 'upstream/master'

528a738

akortunov reviewed Jul 21, 2017

View reviewed changes

akortunov mentioned this pull request Jun 15, 2018

Add murder bounty when a player follower commits murder #1760

Merged

psi29a closed this Jun 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

No murder bounty when a player follower commits murder (Bug #2852) #921

No murder bounty when a player follower commits murder (Bug #2852) #921

NeveHanter commented Apr 1, 2016

ghost Apr 2, 2016

NeveHanter Apr 2, 2016

ghost Apr 2, 2016

NeveHanter Apr 3, 2016

ghost commented Apr 4, 2016

NeveHanter commented Dec 11, 2016 •

edited

Loading

ghost commented Dec 13, 2016

NeveHanter commented Dec 16, 2016

ghost commented Dec 17, 2016

NeveHanter commented Dec 17, 2016 •

edited

Loading

ghost Dec 17, 2016

NeveHanter Dec 17, 2016

NeveHanter Dec 18, 2016

ghost Jan 1, 2017

ghost Jan 1, 2017

ghost Dec 17, 2016

Allofich Dec 19, 2016 •

edited

Loading

NeveHanter Dec 23, 2016

Allofich Dec 24, 2016

jefhai Dec 24, 2016

jefhai commented Dec 22, 2016 •

edited

Loading

NeveHanter commented Dec 23, 2016 •

edited

Loading

Allofich commented Dec 24, 2016

Allofich commented Dec 24, 2016 •

edited

Loading

Allofich commented Dec 27, 2016

ghost commented Jan 1, 2017

akortunov Jul 21, 2017

ghost commented Jul 30, 2017

Capostrophic commented Jun 9, 2018

akortunov commented Jun 19, 2018

psi29a commented Jun 19, 2018

No murder bounty when a player follower commits murder (Bug #2852) #921

No murder bounty when a player follower commits murder (Bug #2852) #921

Conversation

NeveHanter commented Apr 1, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Apr 4, 2016

NeveHanter commented Dec 11, 2016 • edited Loading

ghost commented Dec 13, 2016

NeveHanter commented Dec 16, 2016

ghost commented Dec 17, 2016

NeveHanter commented Dec 17, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Allofich Dec 19, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jefhai commented Dec 22, 2016 • edited Loading

NeveHanter commented Dec 23, 2016 • edited Loading

Allofich commented Dec 24, 2016

Allofich commented Dec 24, 2016 • edited Loading

Allofich commented Dec 27, 2016

ghost commented Jan 1, 2017

Choose a reason for hiding this comment

ghost commented Jul 30, 2017

Capostrophic commented Jun 9, 2018

akortunov commented Jun 19, 2018

psi29a commented Jun 19, 2018

NeveHanter commented Dec 11, 2016 •

edited

Loading

NeveHanter commented Dec 17, 2016 •

edited

Loading

Allofich Dec 19, 2016 •

edited

Loading

jefhai commented Dec 22, 2016 •

edited

Loading

NeveHanter commented Dec 23, 2016 •

edited

Loading

Allofich commented Dec 24, 2016 •

edited

Loading