Fixes core and lib issues for PHP 8.0 compatibility #1391
Conversation
github-actions
bot
added
Component: Adminhtml
|
Unit tests seems to be broken: |
|
sorry about the unittest, the action has a permission issue for sending the results as a comment to the PR. Have modified to allow this step to fail in the future without marking the run as failed. |
|
It seems phpseclib removed create_function altogether. Maybe we could simplify that a little and just follow phpseclib here until we eventually update it? |
|
Have reverted phpseclib changes. Please review. All auto tests are passed |
| @@ -289,7 +289,7 @@ protected static function _decodeYaml($currentIndent, &$lines) | |||
| { | |||
| $config = array(); | |||
| $inIndent = false; | |||
| while (list($n, $line) = each($lines)) { | |||
| foreach($lines as $n => $line) { | |||
There was a problem hiding this comment.
Add space after 'foreach' to meet PSR-4 standards:
foreach ($lines as $n => $line) {
| @@ -88,7 +88,7 @@ public static function getAllCapabilities(TeraWurfl $wurflObj) | |||
| if (!is_array($group)) { | |||
| continue; | |||
| } | |||
| while (list ($key, $value) = each($group)) { | |||
| foreach($group as $key => $value) { | |||
There was a problem hiding this comment.
Add space after 'foreach' to meet PSR-4 standards:
foreach ($group as $key => $value) {
| @@ -486,13 +486,15 @@ protected static function _createSimpleXMLElement(&$xml) | |||
| */ | |||
| protected static function _extractTypeAndValue(SimpleXMLElement $xml, &$type, &$value) | |||
| { | |||
| list($type, $value) = each($xml); | |||
| $value = reset($xml); | |||
There was a problem hiding this comment.
technically this is a logic change, as each() returns the current, and reset() the first.
Also each() moves the internal coursor.
But from the usage here it seems to not matter, and also makes the result more predictable, so Iam ok with leaving it as it is.
|
should we maintain ZF1 by ourselves? I've found this project https://github.com/Shardj/zf1-future/ which I think it's quite interesting, it would have its own challanges but... |
Description (*)
a) Mage_Sales_Model_Quote_Item_Option has getProduct() method which is not taking any parameters!
b) Mage_Catalog_Model_Product_Configuration_Item_Option is Varien_Object derivative, and "product" is just field containing one product data, not a collection inside. (It's causing issue under PHP 8.0 inside Varien_Object::getData() method passing instance of Catalog_Model_Product as $key argument)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)