Commits on 1.9.3.x that are not on 1.9.4.x #2184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* solve longstanding order shortcoming (so actual coupon code on order view) solve longstanding order shortcoming (so actual coupon code on order view in adminhtml) now our logistics see the description @ totals overview: but have to ask the customer: which code was it? esp. handy when using generated codes simple fix: please improve if you think this can be done better. Breaks nothing, quickwin for admin users * Sloppy missed clsoing div * Updated string * Add coupon code translations * Update Mage_Adminhtml.csv * Added coupon code * Escape coupon code and description in template. Co-authored-by: Colin Mollenhour <colin@mollenhour.com>
remove password from account_new email template
* Update shipping.phtml Wrong translation field fix * Fixed typo Co-authored-by: sv3n <github-sr@hotmail.com>
github-actions
bot
added
Component: Adminhtml
|
Nice find but you closed the PR. Are those commits merged in latest OM? Did we miss others? |
|
I don't think there could be something merge in older branches (older than 1.9.3) but I closed it because, at this point in time, it could be dangerous to merge some commits from milion years ago just because we found them. |
|
Can we revert and leave them open for discussions? Or shall we recreate them? |
|
anyone can cherry-pick one any comment into another branch |
|
I will let someone more advanced in Git to do this task. If you can do it would be great because you know what it's about. The most important thing is not to lose them and to capitalize the efforts made in the past if they are still relevant. |
ADDISON74
removed
environment
Component: PayPal
ADDISON74
added
needs rewrite for new versions
and removed
Component: Checkout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since github doesn't allow to dismiss the "compare & pull request" button I've to create this PR. I will close it right away since no commit in the 1.9.3.x branch should be ported to 1.9.4.x at this point in time.
We should probably freeze old branches if possible