Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DEV_PHP_STRICT env variable #2882

Merged
merged 7 commits into from
Jan 3, 2023
Merged

Added DEV_PHP_STRICT env variable #2882

merged 7 commits into from
Jan 3, 2023

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 2, 2023 •
edited by Flyingmana
Loading

Description (*)

When testing against PHP8.1 you have to comment some lines, mentioned in related PRs.

PR adds support for DEV_PHP_STRICT env variable to not change functions.php every time.

DDEV example:

web_environment:
- MAGE_IS_DEVELOPER_MODE=1
- DEV_PHP_STRICT=1

Related Pull Requests

  1. Some changes for compatibility with PHP 8.1 #1812
  2. [PHP 8.1] Fix passing null to non-nullable internal function params #2586

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Jan 2, 2023
@sreichel sreichel marked this pull request as draft January 2, 2023 06:01
@sreichel sreichel marked this pull request as ready for review January 2, 2023 06:07
ADDISON74
ADDISON74 previously approved these changes Jan 2, 2023
View reviewed changes
Flyingmana
Flyingmana previously requested changes Jan 2, 2023
View reviewed changes
Copy link
Member

@Flyingmana Flyingmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs documentation/explanation in code.

Having also a mention in the Readme or our Docs would be nice to have.

@sreichel sreichel marked this pull request as draft January 2, 2023 17:07
Revert "Update"
cad8a5c 
This reverts commit 7909795.
@sreichel sreichel marked this pull request as ready for review January 2, 2023 18:21
ADDISON74
ADDISON74 previously approved these changes Jan 2, 2023
View reviewed changes
@Flyingmana Flyingmana merged commit 1c7bb20 into OpenMage:1.9.4.x Jan 3, 2023
@sreichel sreichel deleted the dev-flag branch January 3, 2023 17:44
fballiano pushed a commit that referenced this pull request Jan 3, 2023
@fballiano
Added DEV_PHP_STRICT env variable (#2882)
83ac4b0 
* Show all errors

* Update

* Revert "Update"

This reverts commit 7909795.

* Added comment

* Updated README.md

* Typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADDISON74 ADDISON74 ADDISON74 approved these changes

@elidrissidev elidrissidev elidrissidev approved these changes

@Flyingmana Flyingmana Flyingmana left review comments

Assignees
No one assigned
Labels
Component: Core Relates to Mage_Core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sreichel @Flyingmana @ADDISON74 @elidrissidev