Fixes passing null to strlen() inside escapeHtml()

[sreichel]

Description (*)

I don't disagree with fixing existing uses of escapeHtml but just for practicality sake this is going to be a big headache for those with lots of extensions so I propose changing the signature of escapeHtml to allow a nullable string (if null is passed it should return an empty string).

We just need to check if we pass as string to strlen() inside escapeHtml(). Should be enough?

Related Pull Requests

• [PHP 8.1] Fix passing null to non-nullable internal function params #2586 (comment)
• [PHP 8.1] Fix passing null to non-nullable internal function params #2586 (comment)

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[sreichel]

Okay ... to late to change it to $data !== ''.

[sreichel]

@Flyingmana @fballiano where is the project tab? I've used that to track some issues. Recently added "PHP8.1"

[fballiano]

My fault, was trying to hide the double “projects/projects classic” and they both got hidden, but now it’s ok and there’s only one projects tab

[colinmollenhour]

Thanks, @sreichel !