Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast return of getClass() to string #2905

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Cast return of getClass() to string #2905

merged 2 commits into from
Jan 6, 2023

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 6, 2023 •
edited
Loading

Description (*)

Next small step for php8.1 ...

Related Pull Requests

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@sreichel sreichel added the PHP 8.1 Related to PHP 8.1 label Jan 6, 2023
@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Widget Relates to Mage_Widget Template : admin Relates to admin template labels Jan 6, 2023
@fballiano fballiano merged commit 85aa619 into OpenMage:1.9.4.x Jan 6, 2023
fballiano pushed a commit that referenced this pull request Jan 6, 2023
@fballiano
Cast return of getClass() to string (#2905)
8a60871
@fballiano
Copy link
Contributor

cherry-picked to 20.0 since there were no conflicts

@sreichel sreichel deleted the fix/php8.1/getTabclass-string branch January 6, 2023 23:27
sreichel added a commit to elidrissidev/magento-lts that referenced this pull request Jan 7, 2023
@sreichel
Apply suggestions from code review. ref OpenMage#2905
e0dfa74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flyingmana Flyingmana Flyingmana approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Widget Relates to Mage_Widget PHP 8.1 Related to PHP 8.1 Template : admin Relates to admin template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sreichel @fballiano @Flyingmana