Template bugs [Please Ignore] #514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flyingmana
reviewed
Sep 5, 2018
app/design/frontend/base/default/template/persistent/customer/form/register.phtml
Show resolved
Hide resolved
|
I would appreciate if you could split this up in two separate PullRequests. Bug 1 is pretty obvious for me But for Bug2 I would need to look a bit more into the code, so this will take a bit longer to review. And it would be sad, if we need to delay the Fix for Bug1 because of this. |
…numeric value encountered" when qty is an empty string. Note that earlier fix using type casting to (int) is faulty when qty is decimal.
…into template_bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1. In PHP7,
$this->getFieldValue('qty')*1will produce a warning A non-numeric value encountered when qty is 0.Bug 2. The first key of the street array is 0 and not 1, resulting in missing street[0] and erroneous street address in the register form. Note that this only affects re-rendering of the register form when there was an exception in an earlier form submit.