Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Bump paperclip from 5.1.0 to 6.1.0 #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Security] Bump paperclip from 5.1.0 to 6.1.0 #43

wants to merge 1 commit into from

Conversation

dependabot-preview[bot]
Copy link

@dependabot-preview dependabot-preview bot commented Nov 8, 2018 •
edited

Bumps paperclip from 5.1.0 to 6.1.0. This update includes security fixes.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Paperclip ruby gem suffers from a Server-Side Request Forgery (SSRF) vulnerability in the Paperclip::UriAdapter and Paperclip::HttpUrlProxyAdapter class.
Paperclip gem provides multiple ways a file can be uploaded to a web server.
The vulnerability affects two of Paperclip’s IO adapters that accept URLs as
attachment data (UriAdapter and HttpUrlProxyAdapter). When these adapters are
used, Paperclip acts as a proxy and downloads the file from the website URI
that is passed in. The library does not perform any validation to protect
against Server Side Request Forgery (SSRF) exploits by default. This may allow
a remote attacker to access information about internal network resources.

Patched versions: >= 5.2.0
Unaffected versions: none

Release notes

Sourced from paperclip's releases.

Version 6.1.0

  • BUGFIX: Don't double-encode URLs (Roderick Monje).
  • BUGFIX: Only use the content_type when it exists (Jean-Philippe Doyle).
  • STABILITY: Better handling of the content-disposition header. Now supports file name that is either enclosed or not in double quotes and is case insensitive as per RC6266 grammar (Hasan Kumar, Yves Riel).
  • STABILITY: Change database column type of attachment file size from unsigned 4-byte integer to unsigned 8-byte bigint. The former type limits attachment size to just over 2GB, which can easily be exceeded by a large video file (Laurent Arnoud, Alen Zamanyan).
  • STABILITY: Better error message when thumbnail processing errors (Hayden Ball).
  • STABILITY: Fix file linking issues around Windows (Akihiko Odaki).
  • STABILITY: Files without an extension will now be checked for spoofing attempts (George Walters II).
  • STABILITY: Manually close Tempfiles when we are done with them (Erkki Eilonen).

v6.0.0

6.0.0 (2018-03-09):

5.3.0 (2018-03-09):

5.2.1 (2018-01-25):

  • Bugfix: Fix copying files on Windows. (#2532)

5.2.0 (2018-01-23):

  • Security: Remove the automatic loading of URI adapters. Some of these
    adapters can be specially crafted to expose your network topology. (#2435)

  • Bugfix: The rake task no longer rescues Exception. (#2476)

  • Bugfix: Handle malformed Content-Disposition headers (#2283)

  • Bugfix: The :only_process option works when passed a lambda again. (#2289)

  • Improvement: Added :use_accelerate_endpoint option when using S3 to enable
    Amazon S3 Transfer Acceleration
    (#2291)

  • Improvement: Make the fingerprint digest configurable per attachment. The
    default remains MD5. Making this configurable means it can change in a future
    version because it is not considered secure anymore against intentional file
    corruption. For more info, see https://en.wikipedia.org/wiki/MD5#Security

    You can change the digest used for an attachment by adding the
    :adapter_options parameter to the has_attached_file options like this:

... (truncated)
Changelog

Sourced from paperclip's changelog.

6.1.0 (2018-07-27):

  • BUGFIX: Don't double-encode URLs (Roderick Monje).
  • BUGFIX: Only use the content_type when it exists (Jean-Philippe Doyle).
  • STABILITY: Better handling of the content-disposition header. Now supports
    file name that is either enclosed or not in double quotes and is case
    insensitive as per RC6266 grammar (Hasan Kumar, Yves Riel).
  • STABILITY: Change database column type of attachment file size from unsigned 4-byte
    integer to unsigned 8-byte bigint. The former type limits attachment size
    to just over 2GB, which can easily be exceeded by a large video file (Laurent
    Arnoud, Alen Zamanyan).
  • STABILITY: Better error message when thumbnail processing errors (Hayden Ball).
  • STABILITY: Fix file linking issues around Windows (Akihiko Odaki).
  • STABILITY: Files without an extension will now be checked for spoofing attempts
    (George Walters II).
  • STABILITY: Manually close Tempfiles when we are done with them (Erkki Eilonen).

6.0.0 (2018-03-09):

5.3.0 (2018-03-09):

5.2.1 (2018-01-25):

  • Bugfix: Fix copying files on Windows. (#2532)

5.2.0 (2018-01-23):

  • Security: Remove the automatic loading of URI adapters. Some of these
    adapters can be specially crafted to expose your network topology. (#2435)
  • Bugfix: The rake task no longer rescues Exception. (#2476)
  • Bugfix: Handle malformed Content-Disposition headers (#2283)
  • Bugfix: The :only_process option works when passed a lambda again. (#2289)
  • Improvement: Added :use_accelerate_endpoint option when using S3 to enable
    Amazon S3 Transfer Acceleration
    (#2291)
  • Improvement: Make the fingerprint digest configurable per attachment. The
... (truncated)
Commits
  • acbb03f Bump 6.1.0 [ci skip]
  • ee144c6 Fix cucumber tests after integer -> bigint conversion
  • 34ec355 Increase attachment file size from int (4 bytes) to bigint (8 bytes).
  • 90f9121 Close + unlink Tempfiles
  • f384174 Rely on URI content_type only when provided.
  • 7eb664f Check for spoofing of files without an extension
  • 0d93e0f add is_windows to option
  • 76a33f0 Update processor.rb
  • 5d9b2ba Update processor.rb
  • 037b975 Update processor.rb
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability labels Nov 8, 2018
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/paperclip-6.1.0 branch from b235098 to 37b0526 Compare February 10, 2019 16:09
@dependabot-support
[Security] Bump paperclip from 5.1.0 to 6.1.0
fb75081 
Bumps [paperclip](https://github.com/thoughtbot/paperclip) from 5.1.0 to 6.1.0. **This update includes security fixes.**
- [Release notes](https://github.com/thoughtbot/paperclip/releases)
- [Changelog](https://github.com/thoughtbot/paperclip/blob/master/NEWS)
- [Commits](thoughtbot/paperclip@v5.1.0...v6.1.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/paperclip-6.1.0 branch from 37b0526 to fb75081 Compare March 26, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dependabot-support