Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pydp folder under src #291

Closed
alejandrosame opened this issue Sep 13, 2020 · 7 comments
Closed

Move pydp folder under src #291

alejandrosame opened this issue Sep 13, 2020 · 7 comments
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase

Comments

@alejandrosame
Copy link
Member

What?

Python code now lives under ./pydp, leaving our source code distributed over 2 folders.

Why?

All source code should be under ./src folder. In order to have a clean repository, we might need to restructure folders inside ./src and refactor the way the bindings are made. However, it shouldn’t be too much of a drastic change (mostly folder renaming, with its corresponding bazel configuration changes).

@alejandrosame alejandrosame added Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase labels Sep 13, 2020
@alejandrosame alejandrosame added this to the Repository improvements milestone Sep 13, 2020
@chinmayshah99
Copy link
Member

Note: This would require playing with bazel configuration. Familiarity with bazel (or willingness to learn about bazel features) is a must.

@siddhesh1598
Copy link
Contributor

Can I work on this? I am not familiar with bazel, but I would like to learn and work on it.

@chinmayshah99
Copy link
Member

Sure, hit us on slack channel #lib_pydp if you need anything

@siddhesh1598
Copy link
Contributor

Alright, will do.

@chinmayshah99
Copy link
Member

hi @siddhesh1598, how is it coming along?

@siddhesh1598
Copy link
Contributor

Hey @chinmayshah99, so far so good. Started learning the bazel config and cloned the repo. Will soon make changes to it.

@alejandrosame
Copy link
Member Author

Fixed on #332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase
Projects
None yet
Development

No branches or pull requests

3 participants