Skip to content

Commit

Permalink
Minor cleanups
Browse files Browse the repository at this point in the history
  • Loading branch information
Markus von Rüden committed Jul 29, 2014
1 parent e7cbeb8 commit d5dacd4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import java.util.Map;

// TODO mvr document and add license text
public class JmxUtils {
public final class JmxUtils {

/**
* Converts, so that we only have Strings, all non String value parameters will be removed.
Expand All @@ -30,4 +30,8 @@ public static Map<String, String> convertToStringMap(Map<String, Object> map) {
return null;
}

private JmxUtils() {

}

}
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,16 @@
import junit.framework.Assert;
import org.junit.Test;
import org.opennms.netmgt.jmx.connection.connectors.DefaultConnectionManager;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.lang.reflect.Field;

public class ConnectorsTest {

private static final Logger LOG = LoggerFactory.getLogger(ConnectorsTest.class);

@Test
public void testConnectionHasConnectorAssigned() throws IllegalAccessException, MBeanServerConnectionException {
DefaultConnectionManager connectionManager = new DefaultConnectionManager();

for (Field eachField : Connectors.class.getFields()) {

Object connectorName = eachField.get(null);
Assert.assertNotNull(connectorName);
Assert.assertEquals(String.class, connectorName.getClass());
Expand Down

0 comments on commit d5dacd4

Please sign in to comment.