Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMS-13685: Create instructions how to build OpenNMS from source #3875

Merged
merged 7 commits into from
Nov 30, 2021
Merged

NMS-13685: Create instructions how to build OpenNMS from source #3875

merged 7 commits into from
Nov 30, 2021

Conversation

indigo423
Copy link
Member

Added instructions on how to build OpenNMS from source code.

External References

@github-actions github-actions bot added the docs label Nov 17, 2021
@indigo423 indigo423 marked this pull request as ready for review November 26, 2021 16:22
Bonrob2
Bonrob2 reviewed Nov 26, 2021
View reviewed changes
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just a few changes.

docs/modules/development/pages/build-from-source.adoc Outdated Show resolved Hide resolved
docs/modules/development/pages/build-from-source.adoc Outdated Show resolved Hide resolved
docs/modules/development/pages/build-from-source.adoc Outdated Show resolved Hide resolved
docs/modules/development/pages/build-from-source.adoc Outdated Show resolved Hide resolved
docs/modules/development/pages/build-from-source.adoc Outdated Show resolved Hide resolved
docs/modules/development/pages/build-from-source.adoc Outdated Show resolved Hide resolved
docs/modules/development/pages/build-from-source.adoc Outdated Show resolved Hide resolved
docs/modules/development/pages/build-from-source.adoc Outdated Show resolved Hide resolved
docs/modules/development/pages/build-from-source.adoc Outdated Show resolved Hide resolved
docs/modules/development/pages/development.adoc Outdated Show resolved Hide resolved
@indigo423 @Bonrob2
NMS-13685: Update review suggestions
4e71784 
Co-authored-by: Bonrob2 <59453630+Bonrob2@users.noreply.github.com>
Bonrob2
Bonrob2 reviewed Nov 29, 2021
View reviewed changes
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, and one question. Thanks for all the work on this!

docs/modules/development/pages/build-from-source.adoc Show resolved Hide resolved
docs/modules/development/pages/build-from-source.adoc Outdated Show resolved Hide resolved
docs/modules/development/pages/build-from-source.adoc Outdated Show resolved Hide resolved
docs/modules/development/pages/development.adoc Outdated Show resolved Hide resolved
docs/modules/development/pages/development.adoc Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@indigo423 @Bonrob2
NMS-13685: Apply suggestions from code review
b2d0dfb 
Co-authored-by: Bonrob2 <59453630+Bonrob2@users.noreply.github.com>
Bonrob2
Bonrob2 previously approved these changes Nov 29, 2021
View reviewed changes
indigo423
indigo423 commented Nov 29, 2021
View reviewed changes
Copy link
Member Author

@indigo423 indigo423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bonrob2 thanks for the suggestions, merged.

README.md Show resolved Hide resolved
RangerRick
RangerRick previously approved these changes Nov 29, 2021
View reviewed changes
Bonrob2
Bonrob2 approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not feel qualified to review this but am approving, in the hopes that someone else will make sure it's correct. :-)

@indigo423 indigo423 merged commit cb48cfd into foundation-2021 Nov 30, 2021
@indigo423 indigo423 deleted the jira/NMS-13685 branch November 30, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangerRick RangerRick RangerRick approved these changes

@Bonrob2 Bonrob2 Bonrob2 approved these changes

@patrick-schweizer patrick-schweizer Awaiting requested review from patrick-schweizer

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@indigo423 @RangerRick @patrick-schweizer @Bonrob2